Bug 137949 - [EFL] build-webkit should try harder to avoid re-running cmake
Summary: [EFL] build-webkit should try harder to avoid re-running cmake
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 137818
  Show dependency tree / graph
 
Reported: 2014-10-22 04:10 PDT by Csaba Osztrogonác
Modified: 2014-10-29 03:45 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.85 KB, patch)
2014-10-22 04:19 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2014-10-22 04:10:57 PDT 
GTK already re-run cmake only if it is necessary:
http://trac.webkit.org/changeset/162545 ( bug127073 )

I think the configuration change detection in shouldRemoveCMakeCache()
is safe, and it seems it has worked well since half years for GTK.

So I propose to use this mechanism for EFL port too. It would 
make incremantal build faster for developers and buildbots too.
Comment 1 Csaba Osztrogonác 2014-10-22 04:19:41 PDT 
Created attachment 240262 [details]
Patch
Comment 2 Csaba Osztrogonác 2014-10-22 04:25:54 PDT 
This change decreased the incremental build time from 36 seconds to 8 seconds
on my desktop machine if I didn't touch any files.
Comment 3 WebKit Commit Bot 2014-10-29 03:45:24 PDT 
Comment on attachment 240262 [details]
Patch

Clearing flags on attachment: 240262

Committed r175327: <http://trac.webkit.org/changeset/175327>
Comment 4 WebKit Commit Bot 2014-10-29 03:45:29 PDT 
All reviewed patches have been landed.  Closing bug.