Bug 137937 - Remove erroneous canUseJIT() in the intrinsics version of JITThunks::hostFunctionStub().
Summary: Remove erroneous canUseJIT() in the intrinsics version of JITThunks::hostFunc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-21 16:58 PDT by Mark Lam
Modified: 2014-10-21 17:52 PDT (History)
1 user (show)

See Also:

Attachments
the patch. (2.10 KB, patch)
2014-10-21 17:12 PDT, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-10-21 16:58:39 PDT 
This version of JITThunks::hostFunctionStub() can only be called from the intrinsics version of VM::getHostFunction() which asserts canUseJIT().  Hence, we can eliminate the canUseJIT() check in JITThunks::hostFunctionStub().  We don't handle the !canUseJIT() case properly there anyway.
Comment 1 Mark Lam 2014-10-21 17:12:23 PDT 
Created attachment 240230 [details]
the patch.
Comment 2 Michael Saboff 2014-10-21 17:14:00 PDT 
Comment on attachment 240230 [details]
the patch.

r=me
Comment 3 WebKit Commit Bot 2014-10-21 17:52:39 PDT 
Comment on attachment 240230 [details]
the patch.

Clearing flags on attachment: 240230

Committed r175005: <http://trac.webkit.org/changeset/175005>
Comment 4 WebKit Commit Bot 2014-10-21 17:52:42 PDT 
All reviewed patches have been landed.  Closing bug.