Bug 137934 - import-w3c-tests should use re.escape() wherever it's handling file paths
Summary: import-w3c-tests should use re.escape() wherever it's handling file paths
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-21 15:08 PDT by Rebecca Hauck
Modified: 2014-10-28 10:52 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.45 KB, patch)
2014-10-22 16:08 PDT, Rebecca Hauck 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rebecca Hauck 2014-10-21 15:08:10 PDT 
test_converter.py does some path conversions where it uses re.sub().  Since filepaths can have regex characters in them, they should all be escaped.
Comment 1 Rebecca Hauck 2014-10-22 16:08:49 PDT 
Created attachment 240301 [details]
Patch
Comment 2 Bem Jones-Bey 2014-10-28 09:37:50 PDT 
Comment on attachment 240301 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-10-28 10:52:28 PDT 
Comment on attachment 240301 [details]
Patch

Clearing flags on attachment: 240301

Committed r175257: <http://trac.webkit.org/changeset/175257>
Comment 4 WebKit Commit Bot 2014-10-28 10:52:31 PDT 
All reviewed patches have been landed.  Closing bug.