WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
137932
[Win] Run DumpRenderTree using native controls, not SafariTheme.dll
https://bugs.webkit.org/show_bug.cgi?id=137932
Summary
[Win] Run DumpRenderTree using native controls, not SafariTheme.dll
Brent Fulgham
Reported
2014-10-21 13:34:10 PDT
It's time to stop using SafariTheme.dll during DumpRenderTree testing. We don't ship software using SafariTheme.dll anymore, so it's silly to use its output as the basis for our rendering health. Furthermore, with the release of Yosemite, the drawing style used in SafariTheme no longer matches our Mac baselines. Consequently, many tests will begin failing anyway. Let's seize this opportunity to rebaseline Windows against its native drawing style.
Attachments
Patch
(2.00 KB, patch)
2014-10-21 13:37 PDT
,
Brent Fulgham
simon.fraser
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2014-10-21 13:37:43 PDT
Created
attachment 240220
[details]
Patch
Brent Fulgham
Comment 2
2014-10-21 14:13:51 PDT
Committed
r174998
: <
http://trac.webkit.org/changeset/174998
>
Brent Fulgham
Comment 3
2014-10-21 17:26:49 PDT
Small set of test expectations updated in
r175004
. <
http://trac.webkit.org/changeset/175004
>.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug