Bug 137932 - [Win] Run DumpRenderTree using native controls, not SafariTheme.dll
Summary: [Win] Run DumpRenderTree using native controls, not SafariTheme.dll
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Brent Fulgham
Depends on:
Blocks: 25592
  Show dependency treegraph
Reported: 2014-10-21 13:34 PDT by Brent Fulgham
Modified: 2014-10-21 17:26 PDT (History)
1 user (show)

See Also:

Patch (2.00 KB, patch)
2014-10-21 13:37 PDT, Brent Fulgham
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-10-21 13:34:10 PDT
It's time to stop using SafariTheme.dll during DumpRenderTree testing. We don't ship software using SafariTheme.dll anymore, so it's silly to use its output as the basis for our rendering health.

Furthermore, with the release of Yosemite, the drawing style used in SafariTheme no longer matches our Mac baselines. Consequently, many tests will begin failing anyway.

Let's seize this opportunity to rebaseline Windows against its native drawing style.
Comment 1 Brent Fulgham 2014-10-21 13:37:43 PDT
Created attachment 240220 [details]
Comment 2 Brent Fulgham 2014-10-21 14:13:51 PDT
Committed r174998: <http://trac.webkit.org/changeset/174998>
Comment 3 Brent Fulgham 2014-10-21 17:26:49 PDT
Small set of test expectations updated in r175004. <http://trac.webkit.org/changeset/175004>.