Bug 137931 - Web Inspector: Fix generator importing of protocol type "any", treat as value
Summary: Web Inspector: Fix generator importing of protocol type "any", treat as value
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-21 12:40 PDT by Joseph Pecoraro
Modified: 2014-10-22 12:11 PDT (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (7.10 KB, patch)
2014-10-21 12:42 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (7.10 KB, patch)
2014-10-21 13:52 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-10-21 12:40:43 PDT 
The generator import of type "any" was using "getAny" which does not exist. Add the boilerplate for a "getValue".

This is currently unused, otherwise we would have gotten compiler warnings. Arguably we could switch to disallow incoming "any" types, but it is supportable, so I just did a quick implementation.
Comment 1 Joseph Pecoraro 2014-10-21 12:42:13 PDT 
Created attachment 240216 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2014-10-21 12:44:51 PDT 
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 3 Joseph Pecoraro 2014-10-21 13:52:02 PDT 
Created attachment 240221 [details]
[PATCH] Proposed Fix
Comment 4 WebKit Commit Bot 2014-10-22 12:11:17 PDT 
Comment on attachment 240221 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 240221

Committed r175059: <http://trac.webkit.org/changeset/175059>
Comment 5 WebKit Commit Bot 2014-10-22 12:11:21 PDT 
All reviewed patches have been landed.  Closing bug.