Bug 137923 - [EME][Mac] Update to match new AVStreamSession API and requirements.
Summary: [EME][Mac] Update to match new AVStreamSession API and requirements.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-10-21 08:17 PDT by Jer Noble
Modified: 2014-12-16 13:28 PST (History)
5 users (show)

See Also:

Attachments
Patch (25.87 KB, patch)
2014-10-21 09:06 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
Patch for landing (25.67 KB, patch)
2014-10-21 14:35 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (25.73 KB, patch)
2014-10-21 15:48 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (25.73 KB, patch)
2014-10-21 15:49 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-10-21 08:17:38 PDT 
[EME][Mac] Update to match new AVStreamSession API and requirements.
Comment 1 Jer Noble 2014-10-21 09:06:50 PDT 
Created attachment 240208 [details]
Patch
Comment 2 Eric Carlson 2014-10-21 14:17:29 PDT 
Comment on attachment 240208 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240208&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:285
> +    if (m_streamSession) {

Minor nit: this could be an early return

> Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:699
> +    UNUSED_PARAM(trackID);

Nit: this could be in an "#else" block below.
Comment 3 Jer Noble 2014-10-21 14:35:57 PDT 
Created attachment 240222 [details]
Patch for landing
Comment 4 Jer Noble 2014-10-21 15:48:29 PDT 
Created attachment 240224 [details]
Patch for landing
Comment 5 Jer Noble 2014-10-21 15:49:02 PDT 
Created attachment 240226 [details]
Patch for landing
Comment 6 Jer Noble 2014-10-21 16:07:00 PDT 
Committed r175000: <http://trac.webkit.org/changeset/175000>
Comment 7 Jer Noble 2014-12-16 13:28:18 PST 
<rdar://problem/19269055>