Bug 137921 – [GTK]: Fix unused parameter build warnings in WebCore/platform module

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Rohit]

Remove following build warning in WebKit GTK build

[192/4427] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/dfg/DFGCommon.cpp.o
[2493/4427] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/ScrollAnimatorNone.cpp.o
../../Source/WebCore/platform/ScrollAnimatorNone.cpp:199:1: warning: unused parameter ‘parent’ [-Wunused-parameter]
 ScrollAnimatorNone::PerAxisData::PerAxisData(ScrollAnimatorNone* parent, float* currentPosition, int visibleLength)
 ^
../../Source/WebCore/platform/ScrollAnimatorNone.cpp:494:6: warning: unused parameter ‘timer’ [-Wunused-parameter]
 void ScrollAnimatorNone::animationTimerFired(Timer<ScrollAnimatorNone>* timer)
      ^
[2555/4427] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/cairo/CairoUtilities.cpp.o

[Rohit]

Created attachment 240200 [details]
Patch

[WebKit Commit Bot]

Attachment 240200 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Carlos Garcia Campos]

Comment on attachment 240200 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240200&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

You should remove this line

[Rohit]

Created attachment 240258 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 240258 [details]
Patch for landing

Clearing flags on attachment: 240258

Committed r175037: <http://trac.webkit.org/changeset/175037>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.