Bug 137920 - [Curl] Optimization; avoid string reallocation.
Summary: [Curl] Optimization; avoid string reallocation.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-21 06:36 PDT by peavo
Modified: 2014-10-21 12:41 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.79 KB, patch)
2014-10-21 06:42 PDT, peavo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2014-10-21 06:36:13 PDT 
Profiling reveals that the cookiesForDOM function is spending time on removing a character from a string.
Comment 1 peavo 2014-10-21 06:42:49 PDT 
Created attachment 240198 [details]
Patch
Comment 2 Brent Fulgham 2014-10-21 12:05:51 PDT 
Comment on attachment 240198 [details]
Patch

r=me. It's always great to avoid having to create/modify a string when all you want to do is query it!
Comment 3 peavo 2014-10-21 12:33:57 PDT 
(In reply to comment #2)
> Comment on attachment 240198 [details]
> Patch
> 
> r=me. It's always great to avoid having to create/modify a string when all
> you want to do is query it!

Thanks!
Comment 4 WebKit Commit Bot 2014-10-21 12:41:46 PDT 
Comment on attachment 240198 [details]
Patch

Clearing flags on attachment: 240198

Committed r174993: <http://trac.webkit.org/changeset/174993>
Comment 5 WebKit Commit Bot 2014-10-21 12:41:49 PDT 
All reviewed patches have been landed.  Closing bug.