error log: ../../Source/WebCore/rendering/RenderLayerBacking.cpp: In member function 'bool WebCore::RenderLayerBacking::isDirectlyCompositedImage() const': ../../Source/WebCore/rendering/RenderLayerBacking.cpp:1823:44: error: 'RenderMedia' was not declared in this scope ../../Source/WebCore/rendering/RenderLayerBacking.cpp:1823:67: error: no matching function for call to 'is(WebCore::RenderLayerModelObject&)' RenderMedia class is inside ENABLE(VIDEO) guard, that's why it causes build failure. The previous renderer().isMedia() worked, because isMedia() is defined unconditionally in RenderObject (returns false) - the base class of RenderMedia (returns true).
Thanks for the bug report Ossy, I'm on it!
Committed r174978: <http://trac.webkit.org/changeset/174978>
(In reply to comment #2) > Committed r174978: <http://trac.webkit.org/changeset/174978> But the whole RenderMedia.h is inside ENABLE(VIDEO) guard, it can't fix the build.
Apparently did not fix the build.
Created attachment 240210 [details] Patch
Ossy, sorry about the quick / insufficient build fix. What do you think about this one?
(In reply to comment #6) > Ossy, sorry about the quick / insufficient build fix. What do you think > about this one? Looks good for the error in the description, let me check if it is enough, maybe there are other issues later.
Comment on attachment 240210 [details] Patch Thanks, I tested, it is enough to fix the build, r=me.
(In reply to comment #8) > Comment on attachment 240210 [details] > Patch > > Thanks, I tested, it is enough to fix the build, r=me. Great, thanks for double-checking and sorry about the breakage.
Comment on attachment 240210 [details] Patch Clearing flags on attachment: 240210 Committed r174989: <http://trac.webkit.org/changeset/174989>
All reviewed patches have been landed. Closing bug.