Bug 137916 – REGRESSION(r174676): It broke the !ENABLE(VIDEO) build

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Csaba Osztrogonác]

error log:
../../Source/WebCore/rendering/RenderLayerBacking.cpp: In member function 'bool WebCore::RenderLayerBacking::isDirectlyCompositedImage() const':
../../Source/WebCore/rendering/RenderLayerBacking.cpp:1823:44: error: 'RenderMedia' was not declared in this scope
../../Source/WebCore/rendering/RenderLayerBacking.cpp:1823:67: error: no matching function for call to 'is(WebCore::RenderLayerModelObject&)'

RenderMedia class is inside ENABLE(VIDEO) guard, that's why it causes build failure.
The previous renderer().isMedia() worked, because isMedia() is defined unconditionally
in RenderObject (returns false) - the base class of RenderMedia (returns true).

[Chris Dumez]

Thanks for the bug report Ossy, I'm on it!

[Chris Dumez]

Committed r174978: <http://trac.webkit.org/changeset/174978>

[Csaba Osztrogonác]

(In reply to comment #2)
> Committed r174978: <http://trac.webkit.org/changeset/174978>

But the whole RenderMedia.h is inside ENABLE(VIDEO) guard, it can't
fix the build.

[Chris Dumez]

Apparently did not fix the build.

[Chris Dumez]

Created attachment 240210 [details]
Patch

[Chris Dumez]

Ossy, sorry about the quick / insufficient build fix. What do you think about this one?

[Csaba Osztrogonác]

(In reply to comment #6)
> Ossy, sorry about the quick / insufficient build fix. What do you think
> about this one?

Looks good for the error in the description, let me check if it is enough, 
maybe there are other issues later.

[Csaba Osztrogonác]

Comment on attachment 240210 [details]
Patch

Thanks, I tested, it is enough to fix the build, r=me.

[Chris Dumez]

(In reply to comment #8)
> Comment on attachment 240210 [details]
> Patch
> 
> Thanks, I tested, it is enough to fix the build, r=me.

Great, thanks for double-checking and sorry about the breakage.

[WebKit Commit Bot]

Comment on attachment 240210 [details]
Patch

Clearing flags on attachment: 240210

Committed r174989: <http://trac.webkit.org/changeset/174989>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.