Bug 13791 - Autogenerate the JS bindings for the HTMLIFrameElement and HTMLFrameElement
Summary: Autogenerate the JS bindings for the HTMLIFrameElement and HTMLFrameElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 13779
  Show dependency tree / graph
 
Reported: 2007-05-20 18:19 PDT by Sam Weinig
Modified: 2007-05-21 15:52 PDT (History)
0 users

See Also:

Attachments
patch (39.70 KB, patch)
2007-05-20 18:22 PDT, Sam Weinig 		sam: review-
Details | Formatted Diff | Diff
updated patch (35.99 KB, patch)
2007-05-21 09:52 PDT, Sam Weinig 		aroben: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2007-05-20 18:19:18 PDT 
Patch forthcoming.
Comment 1 Sam Weinig 2007-05-20 18:22:40 PDT 
Created attachment 14638 [details]
patch
Comment 2 Adam Roben (:aroben) 2007-05-20 18:34:13 PDT 
Comment on attachment 14638 [details]
patch

Is it possible to merge JSHTMLFrameElementCustom.cpp and JSHTMLIFrameElementCustom.cpp into one file that uses HTMLFrameOwnerElement? It seems a shame to have this duplicated code.
Comment 3 Sam Weinig 2007-05-21 09:52:11 PDT 
Created attachment 14643 [details]
updated patch

Instead of using [Custom] to implement the security check I have added a [CheckSecurity] attribute and updated the bindings scripts to handle it.  This should resolves the code duplication issue and makes the patch a little cleaner.
Comment 4 Adam Roben (:aroben) 2007-05-21 10:31:41 PDT 
Comment on attachment 14643 [details]
updated patch

+ // alias for DOM JS DOM bindings

I don't think you need two of them are needed.

r=me
Comment 5 Sam Weinig 2007-05-21 15:52:47 PDT 
Landed in r21624.