Bug 137899 – Avoid confusion between AccessibilityObject::isTable() / isAccessibilityTable()

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[Chris Dumez]

Avoid confusion between AccessibilityObject::isTable() / isAccessibilityTable().

isTable() is equivalent to is<AccessibilityTable>(), while isAccessibilityTable() is an AccessibilityTable that is exposed as an AccessibilityTable to the platform.
We should likely rename isAccessibilityTable() to something else (maybe isExposedThroughAccessibility()?), have it on AccessibilityTable class only and make it non-virtual.

[Chris Dumez]

Created attachment 240165 [details]
Patch

[WebKit Commit Bot]

Attachment 240165 [details] did not pass style-queue:


ERROR: Source/WebCore/accessibility/AccessibilityTable.cpp:585:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 240168 [details]
Patch

[WebKit Commit Bot]

Attachment 240168 [details] did not pass style-queue:


ERROR: Source/WebCore/accessibility/AccessibilityTable.cpp:585:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 240173 [details]
Patch

[WebKit Commit Bot]

Attachment 240173 [details] did not pass style-queue:


ERROR: Source/WebCore/accessibility/AccessibilityTable.cpp:585:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 240175 [details]
Patch

[WebKit Commit Bot]

Attachment 240175 [details] did not pass style-queue:


ERROR: Source/WebCore/accessibility/AccessibilityTable.cpp:585:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Chris Dumez]

Created attachment 240177 [details]
Patch

[WebKit Commit Bot]

Attachment 240177 [details] did not pass style-queue:


ERROR: Source/WebCore/accessibility/AccessibilityTable.cpp:585:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 240177 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240177&action=review

While I do think we are getting more clarity here, the really verbose repeated is && downcast dance is irritating. I wish there was a cleaner way to write all of those.

> Source/WebCore/accessibility/AccessibilityARIAGridCell.cpp:66
> +    if (!is<AccessibilityTable>(parent) || !downcast<AccessibilityTable>(*parent).isExposableThroughAccessibility())
>          return nullptr;

Maybe this would read better as !(a && b) rather than !a || !b?

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1631
> +    if (is<AccessibilityList>(*obj)
> +        || (is<AccessibilityTable>(*obj) && downcast<AccessibilityTable>(*obj).isExposableThroughAccessibility())
> +        || obj->isTree()
> +        || obj->isCanvas())
>          return false;

How about 3 or 4 separate if statements? I don’t see why we need to use one with || here.

> Source/WebCore/accessibility/AccessibilityTable.cpp:54
> +    , m_isExposableThroughAccessibility(true)

Seems a little strange to initialize this both here and in the init function. It seems like we’d have a problem if we looked at this before calling init.

> Source/WebCore/accessibility/AccessibilityTable.h:63
> +    virtual int tableLevel() const override final;

Glad you marked this final. I’d like to see more of these public virtual override functions made private, protected, or final.

> Source/WebCore/accessibility/AccessibilityTable.h:96
> +    virtual bool computeIsTableExposableThroughAccessibility() const;

Not sure why this is protected instead of private. Do derived classes call through to the base class?

> Source/WebCore/accessibility/AccessibilityTableRow.cpp:79
> -    if (!table || !table->isAccessibilityTable())
> +    if (!is<AccessibilityTable>(table) || !downcast<AccessibilityTable>(*table).isExposableThroughAccessibility())
>          return false;
>      
>      return true;

This should be:

    return is<AccessibilityTable>(table) && downcast<AccessibilityTable>(*table).isExposableThroughAccessibility();

> Source/WebCore/accessibility/AccessibilityTableRow.cpp:110
>          if (is<AccessibilityTable>(*parent))
> -            return downcast<AccessibilityTable>(*parent).isAccessibilityTable() ? downcast<AccessibilityTable>(parent) : nullptr;
> +            return downcast<AccessibilityTable>(*parent).isExposableThroughAccessibility() ? downcast<AccessibilityTable>(parent) : nullptr;

Seems like this goes out of its way to use ? : when it could just fall through to return nullptr.

[Chris Dumez]

Created attachment 240293 [details]
Patch

[WebKit Commit Bot]

Attachment 240293 [details] did not pass style-queue:


ERROR: Source/WebCore/accessibility/AccessibilityTable.cpp:585:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 240293 [details]
Patch

Clearing flags on attachment: 240293

Committed r175068: <http://trac.webkit.org/changeset/175068>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.