Bug 137898 – Action menu items should have tags

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Beth Dakin]

Action menu items should have tags.

[Beth Dakin]

Created attachment 240156 [details]
Patch

[WebKit Commit Bot]

Attachment 240156 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:58:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Beth Dakin]

(In reply to comment #2)
> Attachment 240156 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebKit2/UIProcess/API/mac/WKView.mm:58:  Alphabetical sorting
> problem.  [build/include_order] [4]
> Total errors found: 1 in 4 files
> 
> 
> If any of these errors are false positives, please file a bug against
> check-webkit-style.

Fixed!

[Anders Carlsson]

Comment on attachment 240156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240156&action=review

> Source/WebKit2/Shared/API/c/WKActionMenuItemTypes.h:41
> +typedef uint32_t WKActionMenuItemTag;

I don't think we need this typedef, do we!

[Beth Dakin]

(In reply to comment #4)
> Comment on attachment 240156 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240156&action=review
> 
> > Source/WebKit2/Shared/API/c/WKActionMenuItemTypes.h:41
> > +typedef uint32_t WKActionMenuItemTag;
> 
> I don't think we need this typedef, do we!

Good point!

http://trac.webkit.org/changeset/174913

Thanks Anders!

[Joseph Pecoraro]

Comment on attachment 240156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240156&action=review

> Source/WebKit2/Shared/API/c/WKActionMenuItemTypes.h:29
> +#include <stdint.h>

Does that mean this include can go away too?