Bug 137896 - Use is<>() / downcast<>() for SpinButtonElement
Summary: Use is<>() / downcast<>() for SpinButtonElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-20 15:20 PDT by Chris Dumez
Modified: 2014-10-20 18:19 PDT (History)
16 users (show)

See Also:


Attachments
Patch (5.12 KB, patch)
2014-10-20 15:30 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (5.20 KB, patch)
2014-10-20 15:40 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-10-20 15:20:56 PDT
Use is<>() / downcast<>() for SpinButtonElement instead of isSpinButtonElement() / static_cast.
Comment 1 Chris Dumez 2014-10-20 15:30:09 PDT
Created attachment 240149 [details]
Patch
Comment 2 Chris Dumez 2014-10-20 15:40:35 PDT
Created attachment 240151 [details]
Patch
Comment 3 Gyuyoung Kim 2014-10-20 17:39:05 PDT
Comment on attachment 240151 [details]
Patch

LGTM.
Comment 4 WebKit Commit Bot 2014-10-20 18:19:22 PDT
Comment on attachment 240151 [details]
Patch

Clearing flags on attachment: 240151

Committed r174917: <http://trac.webkit.org/changeset/174917>
Comment 5 WebKit Commit Bot 2014-10-20 18:19:30 PDT
All reviewed patches have been landed.  Closing bug.