Bug 137895 - REGRESSION: Google Search (mobile) video thumbnails are too large.
Summary: REGRESSION: Google Search (mobile) video thumbnails are too large.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2014-10-20 14:30 PDT by zalan
Modified: 2014-11-12 21:30 PST (History)
7 users (show)

See Also:

Attachments
Patch (11.19 KB, patch)
2014-10-20 17:51 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (11.24 KB, patch)
2014-10-21 08:57 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2014-10-20 14:30:38 PDT 
1. Open google.com with iOS user agent string.
1. Search for something with videos.
3. Tap the "videos".
Notice that the video thumbnail overlay the title/text.
Comment 1 zalan 2014-10-20 14:31:57 PDT 
rdar://problem/18559546
Comment 2 zalan 2014-10-20 17:51:31 PDT 
Created attachment 240167 [details]
Patch
Comment 3 Simon Fraser (smfr) 2014-10-20 17:54:09 PDT 
Comment on attachment 240167 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240167&action=review

> Source/WebCore/rendering/RenderLayer.h:101
> +    bool effectedByRadius() const { return m_effectedByRadius; }
> +    void setEffectedByRadius(bool effectedByRadius) { m_effectedByRadius = effectedByRadius; }

effected -> affected everywhere.
Comment 4 zalan 2014-10-21 08:57:23 PDT 
Created attachment 240207 [details]
Patch
Comment 5 WebKit Commit Bot 2014-10-21 10:32:12 PDT 
Comment on attachment 240207 [details]
Patch

Clearing flags on attachment: 240207

Committed r174986: <http://trac.webkit.org/changeset/174986>
Comment 6 WebKit Commit Bot 2014-10-21 10:32:16 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Simon Fraser (smfr) 2014-11-12 21:30:30 PST 
This broke css "clip".