WK2 should support action menus. rdar://problem/18451638 rdar://problem/18694470
Created attachment 240141 [details] Patch
Attachment 240141 [details] did not pass style-queue: ERROR: Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 2 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Attachment 240141 [details] did not pass style-queue: > > > ERROR: Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number > [changelog/bugnumber] [5] > ERROR: Source/WebCore/ChangeLog:1: ChangeLog entry has no bug number > [changelog/bugnumber] [5] > Total errors found: 2 in 13 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. Oops! Fixed this.
Created attachment 240143 [details] Patch with slightly different WK2 spin
Comment on attachment 240143 [details] Patch with slightly different WK2 spin View in context: https://bugs.webkit.org/attachment.cgi?id=240143&action=review > Source/WebKit2/UIProcess/API/mac/WKView.mm:3710 > + NSMutableArray *menuItems = [NSMutableArray array]; > + > + if (!hitTestResult) > + return menuItems; > + > + if (!hitTestResult->absoluteLinkURL().isEmpty()) > + return [self _defaultMenuItemsForLink]; I'd write this as if (WebHitTestResult* hitTestResult = _data->_page->activeActionMenuHitTestResult()) { if (!hitTestResult->absoluteLinkURL().isEmpty()) return [self _defaultMenuItemsForLink]; } return @[]
Thanks Anders! http://trac.webkit.org/changeset/174908