Bug 137886 - Fix placement of a few items in vcxproj ItemGroups
Summary: Fix placement of a few items in vcxproj ItemGroups
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-20 11:13 PDT by Mark Lam
Modified: 2014-10-20 11:30 PDT (History)
2 users (show)

See Also:

Attachments
The patch. (4.59 KB, patch)
2014-10-20 11:20 PDT, Mark Lam 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2014-10-20 11:13:30 PDT 
https://bugs.webkit.org/show_bug.cgi?id=137873 is likely a cut-and-paste error that manifested because we had ClCompile and ClInclude entries mixed up in the wrong ItemGroups.  We should fix these so that ClCompile entries are in the ClCompile ItemGroup, and ClInclude entries in the ClInclude ItemGroup.  This will help reduce the change of future cut-and-paste errors of this nature.
Comment 1 Brent Fulgham 2014-10-20 11:19:11 PDT 
(In reply to comment #0)
> https://bugs.webkit.org/show_bug.cgi?id=137873 is likely a cut-and-paste
> error that manifested because we had ClCompile and ClInclude entries mixed
> up in the wrong ItemGroups.  We should fix these so that ClCompile entries
> are in the ClCompile ItemGroup, and ClInclude entries in the ClInclude
> ItemGroup.  This will help reduce the change of future cut-and-paste errors
> of this nature.

This is a great idea. We should also extend the style checker to look for these kinds of things.
Comment 2 Mark Lam 2014-10-20 11:20:38 PDT 
Created attachment 240130 [details]
The patch.

Here's the patch, but I'm still need to test this with an actual build before committing.
Comment 3 Geoffrey Garen 2014-10-20 11:24:24 PDT 
Comment on attachment 240130 [details]
The patch.

r=me if it builds
Comment 4 Mark Lam 2014-10-20 11:27:38 PDT 
It builds.  I'll land manually.
Comment 5 Mark Lam 2014-10-20 11:30:30 PDT 
Thanks for the review.  Landed in r174895: <http://trac.webkit.org/r174895>.