Bug 137885 - Make post checkin suggested changes to r174847
Summary: Make post checkin suggested changes to r174847
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-20 10:55 PDT by Michael Saboff
Modified: 2014-10-20 18:21 PDT (History)
0 users

See Also:


Attachments
Patch (1.95 KB, patch)
2014-10-20 14:49 PDT, Michael Saboff
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2014-10-20 10:55:09 PDT
From https://bugs.webkit.org/show_bug.cgi?id=137839#c4

View in context: https://bugs.webkit.org/attachment.cgi?id=240045&action=review

> Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp:65
> +    if (propertyName == Identifier(exec, "open")) {

I believe this is less efficient than:

    if (propertyName == "open") {

> Source/WebCore/bindings/js/JSHTMLDocumentCustom.cpp:76
> +    const HashTableValue* entry = JSHTMLDocument::info()->staticPropHashTable->entry(propertyName);
> +    if (entry) {

Would be nice to put this definition inside the if.
Comment 1 Michael Saboff 2014-10-20 14:49:23 PDT
Created attachment 240147 [details]
Patch
Comment 2 Mark Lam 2014-10-20 15:24:23 PDT
Comment on attachment 240147 [details]
Patch

r=me
Comment 3 Michael Saboff 2014-10-20 16:37:59 PDT
Committed r174913: <http://trac.webkit.org/changeset/174913>
Comment 4 Michael Saboff 2014-10-20 18:20:17 PDT
(In reply to comment #3)
> Committed r174913: <http://trac.webkit.org/changeset/174913>

Changes didn't land with this revision due to webkit-patch issue.
Comment 5 Michael Saboff 2014-10-20 18:21:00 PDT
Committed r174918: <http://trac.webkit.org/changeset/174918>