Bug 137884 - [GTK] Move GtkInputMethodFilter from Platform to WebKit2
Summary: [GTK] Move GtkInputMethodFilter from Platform to WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2014-10-20 10:06 PDT by Carlos Garcia Campos
Modified: 2014-10-22 06:00 PDT (History)
4 users (show)

See Also:


Attachments
Patch (80.88 KB, patch)
2014-10-20 10:18 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Updated the apply on current git master (80.83 KB, patch)
2014-10-20 10:27 PDT, Carlos Garcia Campos
gns: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-10-20 10:06:34 PDT
And merge it with WebViewBaseInputMethodFilter.
Comment 1 Carlos Garcia Campos 2014-10-20 10:18:31 PDT
Created attachment 240128 [details]
Patch
Comment 2 Carlos Garcia Campos 2014-10-20 10:27:18 PDT
Created attachment 240129 [details]
Updated the apply on current git master
Comment 3 WebKit Commit Bot 2014-10-20 10:29:51 PDT
Attachment 240129 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/gtk/InputMethodFilter.cpp:143:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/gtk/InputMethodFilter.cpp:249:  Missing space before {  [whitespace/braces] [5]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Gustavo Noronha (kov) 2014-10-22 04:04:25 PDT
Comment on attachment 240129 [details]
Updated the apply on current git master

This rocks =)
Comment 5 Carlos Garcia Campos 2014-10-22 06:00:19 PDT
Committed r175046: <http://trac.webkit.org/changeset/175046>