Bug 137882 – REGRESSION(r174823): Several tests fail due to canplaythrough firing before tracks are available

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jer Noble]

https://build.webkit.org/results/Apple%20Mavericks%20Debug%20WK2%20(Tests)/r174866%20(7482)/results.html

http/tests/media/hls/video-controls-live-stream.html
http/tests/media/track-in-band-hls-metadata.html

Both failing due to 'canplaythrough' firing earlier than expected (before the videos have tracks).

[Jer Noble]

Committed r174884: <http://trac.webkit.org/changeset/174884>

[Jer Noble]

Above commit was just TestExpectations changes.

[Alexey Proskuryakov]

media/track/audio-track.html appears to be flaky on Yosemite for the same reason.

Marked it as flaky in https://trac.webkit.org/r175218 (on all OS X versions, because the change was not Yosemite specific).

[Radar WebKit Bug Importer]

<rdar://problem/18781989>

[Jer Noble]

(In reply to comment #3)
> media/track/audio-track.html appears to be flaky on Yosemite for the same
> reason.
> 
> Marked it as flaky in https://trac.webkit.org/r175218 (on all OS X versions,
> because the change was not Yosemite specific).

Turns out, it's flakey for a different reason. We're queueing a timer to fire the "addTrack" event, but we're sending the "canplaythrough" event immediately when the KVO fires. This means that they can come slightly out-of-order, but this was always possible, and likely did not have anything to do with the other change.

[Jer Noble]

Created attachment 240992 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 240992 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240992&action=review

Nice!

> LayoutTests/platform/mac/TestExpectations:1503
>  webkit.org/b/137882 media/track/audio-track.html [ Pass Failure ]

Could you please change this to bug 138394?

[Jer Noble]

Committed r175826: <http://trac.webkit.org/changeset/175826>