Bug 137874 - Use std::unique_ptr<>|make_unique<> in PluginView::scheduleRequest()
Summary: Use std::unique_ptr<>|make_unique<> in PluginView::scheduleRequest()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-20 04:04 PDT by Gyuyoung Kim
Modified: 2014-10-20 16:26 PDT (History)
1 user (show)

See Also:

Attachments
Patch for ews (3.45 KB, patch)
2014-10-20 04:09 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (3.42 KB, patch)
2014-10-20 07:10 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch for landing (3.41 KB, patch)
2014-10-20 14:15 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2014-10-20 04:04:40 PDT 
SSIA
Comment 1 Gyuyoung Kim 2014-10-20 04:09:24 PDT 
Created attachment 240107 [details]
Patch for ews
Comment 2 Gyuyoung Kim 2014-10-20 07:10:19 PDT 
Created attachment 240120 [details]
Patch
Comment 3 Andreas Kling 2014-10-20 09:05:17 PDT 
Comment on attachment 240120 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240120&action=review

r=me

> Source/WebCore/plugins/PluginView.h:348
> +        Vector<std::unique_ptr<PluginRequest> > m_requests;

We no longer need the space between > and >.
Comment 4 Gyuyoung Kim 2014-10-20 14:15:13 PDT 
Created attachment 240144 [details]
Patch for landing
Comment 5 Gyuyoung Kim 2014-10-20 14:15:47 PDT 
(In reply to comment #3)
> Comment on attachment 240120 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240120&action=review
> 
> r=me
> 
> > Source/WebCore/plugins/PluginView.h:348
> > +        Vector<std::unique_ptr<PluginRequest> > m_requests;
> 
> We no longer need the space between > and >.

Thanks, done.
Comment 6 WebKit Commit Bot 2014-10-20 16:22:28 PDT 
Comment on attachment 240144 [details]
Patch for landing

Clearing flags on attachment: 240144

Committed r174911: <http://trac.webkit.org/changeset/174911>
Comment 7 WebKit Commit Bot 2014-10-20 16:22:32 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Joseph Pecoraro 2014-10-20 16:24:51 PDT 
Comment on attachment 240144 [details]
Patch for landing

I think the OwnPtr.h #include can be removed. While making these cleanups, as a bonus you may be able to remove headers for even more cleanup!
Comment 9 Gyuyoung Kim 2014-10-20 16:26:35 PDT 
(In reply to comment #8)
> Comment on attachment 240144 [details]
> Patch for landing
> 
> I think the OwnPtr.h #include can be removed. While making these cleanups,
> as a bonus you may be able to remove headers for even more cleanup!

Sure, I also have tried to remove those #include though, some #include has been missed. Let me try to remove it further !