WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
137861
Update <link> and <area> link status
https://bugs.webkit.org/show_bug.cgi?id=137861
Summary
Update <link> and <area> link status
Benjamin Poulain
Reported
2014-10-18 19:04:26 PDT
Update <link> and <area> link status
Attachments
Patch
(150.23 KB, patch)
2014-10-18 19:08 PDT
,
Benjamin Poulain
cdumez
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2014-10-18 19:08:03 PDT
Created
attachment 240080
[details]
Patch
Chris Dumez
Comment 2
2014-10-19 11:55:20 PDT
Comment on
attachment 240080
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=240080&action=review
> Source/WebCore/html/HTMLAreaElement.cpp:69 > + } else if (name == hrefAttr) {
Is this really needed? HTMLAreaElement inherits from HTMLAnchorElement, HTMLAnchorElement::parseAttribute() already does that and is being called below already.
> LayoutTests/fast/css/link-basics.html:22 > + <p><a>WebKit</a> <a href=" ">GREEEN</a> <a href="
http://www.webkit.org/notvisited.html
">GREEN</a></p>
nit: Is this GREEEN instead of GREEN on purpose? If so, could we use something that doesn't look like a typo instead? :)
Benjamin Poulain
Comment 3
2014-10-20 00:31:07 PDT
Committed
r174878
: <
http://trac.webkit.org/changeset/174878
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug