Bug 137861 - Update <link> and <area> link status
Summary: Update <link> and <area> link status
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-18 19:04 PDT by Benjamin Poulain
Modified: 2014-10-20 00:31 PDT (History)
5 users (show)

See Also:

Attachments
Patch (150.23 KB, patch)
2014-10-18 19:08 PDT, Benjamin Poulain 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-10-18 19:04:26 PDT 
Update <link> and <area> link status
Comment 1 Benjamin Poulain 2014-10-18 19:08:03 PDT 
Created attachment 240080 [details]
Patch
Comment 2 Chris Dumez 2014-10-19 11:55:20 PDT 
Comment on attachment 240080 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240080&action=review

> Source/WebCore/html/HTMLAreaElement.cpp:69
> +    } else if (name == hrefAttr) {

Is this really needed? HTMLAreaElement inherits from HTMLAnchorElement, HTMLAnchorElement::parseAttribute() already does that and is being called below already.

> LayoutTests/fast/css/link-basics.html:22
> +    <p><a>WebKit</a> <a href=" ">GREEEN</a> <a href="http://www.webkit.org/notvisited.html">GREEN</a></p>

nit: Is this GREEEN instead of GREEN on purpose? If so, could we use something that doesn't look like a typo instead? :)
Comment 3 Benjamin Poulain 2014-10-20 00:31:07 PDT 
Committed r174878: <http://trac.webkit.org/changeset/174878>