Bug 137855 – REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error

• Status: RESOLVED
• Resolution: FIXED
• Component: Page Loading

[Antti Koivisto]

MIME type sniffing doesn't work on synthesized NSURLResponses.

[Antti Koivisto]

<rdar://problem/18665727>

[Antti Koivisto]

Created attachment 240069 [details]
patch

Comment on attachment 240069 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240069&action=review

> Source/WebCore/platform/network/mac/ResourceResponseMac.mm:69
> +    [headerDictionary setObject:(NSString *)m_mimeType forKey:@"Content-Type"];

This can result in lying to the API client about the content of the response headers from the server. Can we use the -_setMIMEType: (which we use elsewhere in WebCore) instead?

(In reply to comment #3)
> Comment on attachment 240069 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240069&action=review
> 
> > Source/WebCore/platform/network/mac/ResourceResponseMac.mm:69
> > +    [headerDictionary setObject:(NSString *)m_mimeType forKey:@"Content-Type"];
> 
> This can result in lying to the API client about the content of the response
> headers from the server. Can we use the -_setMIMEType: (which we use
> elsewhere in WebCore) instead?

/the -_setMIMEType:/the -_setMIMEType: method/

[Antti Koivisto]

> This can result in lying to the API client about the content of the response
> headers from the server. Can we use the -_setMIMEType: (which we use
> elsewhere in WebCore) instead?

We probably can.

[Antti Koivisto]

Created attachment 240073 [details]
patch 2

[WebKit Commit Bot]

Comment on attachment 240073 [details]
patch 2

Clearing flags on attachment: 240073

Committed r174866: <http://trac.webkit.org/changeset/174866>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Antti Koivisto]

*** Bug 137493 has been marked as a duplicate of this bug. ***