Bug 137850 - [WinCairo] Repaint issues with accelerated compositing.
Summary: [WinCairo] Repaint issues with accelerated compositing.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-18 06:16 PDT by peavo
Modified: 2014-10-18 14:48 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.16 KB, patch)
2014-10-18 06:32 PDT, peavo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2014-10-18 06:16:46 PDT
There are some repaint issues in accelerated compositing mode, for example on www.ddg.gg.
Comment 1 peavo 2014-10-18 06:32:48 PDT
Created attachment 240062 [details]
Patch
Comment 2 Brent Fulgham 2014-10-18 08:47:57 PDT
Comment on attachment 240062 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=240062&action=review

I think this looks fine, but I can't confirm isAcceleratedCompositing at the moment. can you confirm and then I can approve the patch?

> Source/WebKit/win/WebView.cpp:6796
> +    if (!isAcceleratedCompositing())

I don't have WebKit source in front of me. Can you confirm 'isAcceleratedCompositing' is identical to checking m_backingLayer for USE(CA)?
Comment 3 peavo 2014-10-18 09:12:23 PDT
(In reply to comment #2)
> Comment on attachment 240062 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=240062&action=review
> 

Thanks for reviewing :)

> I think this looks fine, but I can't confirm isAcceleratedCompositing at the
> moment. can you confirm and then I can approve the patch?
> 
> > Source/WebKit/win/WebView.cpp:6796
> > +    if (!isAcceleratedCompositing())
> 
> I don't have WebKit source in front of me. Can you confirm
> 'isAcceleratedCompositing' is identical to checking m_backingLayer for
> USE(CA)?

Yes, when m_backingLayer is created, m_isAcceleratedCompositing is set to true, and when m_backingLayer is set to null, m_isAcceleratedCompositing is set to false.
Comment 4 Alex Christensen 2014-10-18 14:11:56 PDT
Comment on attachment 240062 [details]
Patch

This also seems to fix a drawing issue that appeared sometimes during transitions in http://www.w3.org/Talks/2012/0416-CSS-WWW2012/Demos/transitions/demo-transitions-3-shadows.html
Comment 5 WebKit Commit Bot 2014-10-18 14:48:37 PDT
Comment on attachment 240062 [details]
Patch

Clearing flags on attachment: 240062

Committed r174865: <http://trac.webkit.org/changeset/174865>
Comment 6 WebKit Commit Bot 2014-10-18 14:48:40 PDT
All reviewed patches have been landed.  Closing bug.