Bug 137805 – REGRESSION (r170808): Volume slider in built-in media controls only changes volume when thumb is released, not while dragging

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

The volume slider in the built-in media controls doesn’t change the volume continuously as the thumb is being dragged. Instead, volume only changes when it’s released.

To reproduce: navigate to the URL. When music starts playing, hover over the volume button in the media controls, then click and hold the thumb in the volume slider, and while still holding, drag it downwards. Notice that the volume doesn’t decrease. Release the thumb and notice that the volume drops.

This is a regression, caused by <http://trac.webkit.org/r170808>, the fix for bug 134545.

[Jon Lee]

This affects scrubber behavior as well.

rdar://problem/18687059

This is *probably* caused by the volume slider relying on the incorrect behavior of the “change” event and should instead use the “input” event. I do not see a problem with the scrubber though (which was updated to use the “input” event.)

The problem is probably here: http://trac.webkit.org/browser/trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js#L388

The event name should be changed to “input” from “change” (see also line 337 where the timeline was updated correctly.)

[Jer Noble]

*** Bug 137821 has been marked as a duplicate of this bug. ***

[Jer Noble]

Created attachment 240041 [details]
Patch

[Jer Noble]

Created attachment 240125 [details]
Patch for landing

[Jer Noble]

Committed r174972: <http://trac.webkit.org/changeset/174972>

[Hunseop Jeong]

This bug also was seen on EFL port.
Do I apply this patch to 'mediaControlsBase.js'?
I made the bug : https://bugs.webkit.org/show_bug.cgi?id=156970.