Bug 137805 - REGRESSION (r170808): Volume slider in built-in media controls only changes volume when thumb is released, not while dragging
Summary: REGRESSION (r170808): Volume slider in built-in media controls only changes v...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL: http://movies.apple.com/movies/us/app...
Keywords: InRadar, Regression
: 137821 (view as bug list)
Depends on:
Blocks: 137917
  Show dependency treegraph
Reported: 2014-10-16 21:43 PDT by mitz
Modified: 2016-04-25 18:51 PDT (History)
15 users (show)

See Also:

Patch (9.15 KB, patch)
2014-10-17 14:49 PDT, Jer Noble
mitz: review+
Details | Formatted Diff | Diff
Patch for landing (7.29 KB, patch)
2014-10-20 08:35 PDT, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-10-16 21:43:37 PDT
The volume slider in the built-in media controls doesn’t change the volume continuously as the thumb is being dragged. Instead, volume only changes when it’s released.

To reproduce: navigate to the URL. When music starts playing, hover over the volume button in the media controls, then click and hold the thumb in the volume slider, and while still holding, drag it downwards. Notice that the volume doesn’t decrease. Release the thumb and notice that the volume drops.

This is a regression, caused by <http://trac.webkit.org/r170808>, the fix for bug 134545.
Comment 1 Jon Lee 2014-10-16 21:53:11 PDT
This affects scrubber behavior as well.
Comment 2 mitz 2014-10-16 22:05:07 PDT
Comment 3 pom 2014-10-17 03:16:39 PDT
This is *probably* caused by the volume slider relying on the incorrect behavior of the “change” event and should instead use the “input” event. I do not see a problem with the scrubber though (which was updated to use the “input” event.)
Comment 4 pom 2014-10-17 05:46:44 PDT
The problem is probably here: http://trac.webkit.org/browser/trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js#L388

The event name should be changed to “input” from “change” (see also line 337 where the timeline was updated correctly.)
Comment 5 Jer Noble 2014-10-17 14:49:16 PDT
*** Bug 137821 has been marked as a duplicate of this bug. ***
Comment 6 Jer Noble 2014-10-17 14:49:21 PDT
Created attachment 240041 [details]
Comment 7 Jer Noble 2014-10-20 08:35:35 PDT
Created attachment 240125 [details]
Patch for landing
Comment 8 Jer Noble 2014-10-21 09:28:34 PDT
Committed r174972: <http://trac.webkit.org/changeset/174972>
Comment 9 Hunseop Jeong 2016-04-25 18:51:30 PDT
This bug also was seen on EFL port.
Do I apply this patch to 'mediaControlsBase.js'?
I made the bug : https://bugs.webkit.org/show_bug.cgi?id=156970.