Bug 137802 - Make a better use of the available registers when compiling nested selector lists
Summary: Make a better use of the available registers when compiling nested selector l...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks: 137844
  Show dependency tree / graph
 
Reported: 2014-10-16 20:34 PDT by Benjamin Poulain
Modified: 2014-10-18 02:15 PDT (History)
2 users (show)

See Also:

Attachments
Patch (712.74 KB, patch)
2014-10-16 21:08 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-10-16 20:34:00 PDT 
Make a better use of the available registers when compiling nested selector lists
Comment 1 Benjamin Poulain 2014-10-16 21:08:07 PDT 
Created attachment 239993 [details]
Patch
Comment 2 Andreas Kling 2014-10-17 14:14:11 PDT 
Comment on attachment 239993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239993&action=review

r=me. I look forward to seeing how you improve on this further.

> Source/WebCore/cssjit/SelectorCompiler.cpp:137
> +class SelectorList : public Vector<SelectorFragmentList> {

Gross.
Comment 3 Benjamin Poulain 2014-10-17 14:21:00 PDT 
Comment on attachment 239993 [details]
Patch

Clearing flags on attachment: 239993

Committed r174838: <http://trac.webkit.org/changeset/174838>
Comment 4 Benjamin Poulain 2014-10-17 14:21:04 PDT 
All reviewed patches have been landed.  Closing bug.