Bug 13780 - REGRESSION (r21526): Failing fast/parser/bad-xml-slash.html
Summary: REGRESSION (r21526): Failing fast/parser/bad-xml-slash.html
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 523.x (Safari 3)
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Dave Hyatt
Keywords: LayoutTestFailure, Regression
Depends on:
Reported: 2007-05-18 12:43 PDT by mitz
Modified: 2007-05-18 16:08 PDT (History)
1 user (show)

See Also:

Patch that fixes "/" to no longer be an attribute name ever. (4.02 KB, patch)
2007-05-18 15:02 PDT, Dave Hyatt
no flags Details | Formatted Diff | Diff
Address some comments from IRC. (3.83 KB, patch)
2007-05-18 15:23 PDT, Dave Hyatt
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2007-05-18 12:43:49 PDT
fast/parser/bad-xml-slash.html is failing: when opened in r21528 and later, the checkbox is not checked.

The render trees for a selected checkbox and an unselected checkbox are the same, so the failure is only reported when running in pixel mode. I think the test should be changed, if possible, to use the DOM to get the status of the checkbox and dump the result as text.
Comment 1 mitz 2007-05-18 12:47:30 PDT
Most likely regressed in <http://trac.webkit.org/projects/webkit/changeset/21526>.
Comment 2 Dave Hyatt 2007-05-18 15:02:30 PDT
Created attachment 14614 [details]
Patch that fixes "/" to no longer be an attribute name ever.

This patch fixes "/" to no longer ever be part of attribute names (so that it's handled like HTML5 and not like HTML4).

It also became necessary to move the <script/> quirk when doing this since it was relying on "/" being an attribute name.  Since i had to redo that quirk, I went ahead and made sure it only applied to Dashboard as well.  This affects a lot of layout tests that I will patch.
Comment 3 Dave Hyatt 2007-05-18 15:23:16 PDT
Created attachment 14615 [details]
Address some comments from IRC.

Null-check frame() and use frame()->settings() rather than frame()->page()->settings()
Comment 4 Geoffrey Garen 2007-05-18 15:43:09 PDT
Comment on attachment 14615 [details]
Address some comments from IRC.

Comment 5 Dave Hyatt 2007-05-18 16:08:08 PDT