Bug 137778 – [EFL] window.screen.width returns wrong value if more displays are available

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Grzegorz Czajkowski]

ecore_x_screen_size_get() retrieves the size of Ecore_X_Screen, for example,
having two displays of 1680x1050, it will return 33600x1050.

Unlike EFL's MiniBrowser, Firefox and Chrome return screen of the current display.

[Grzegorz Czajkowski]

Created attachment 239948 [details]
Patch

[Jinwoo Song]

Looks good to me.

[Gyuyoung Kim]

Comment on attachment 239948 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239948&action=review

> Source/WebCore/platform/efl/PlatformScreenEfl.cpp:94
> +    if (ecore_x_randr_query() && ecore_x_window_focus_get())

ecore_x_window_focus_get() is called twice. How about using a variable to handle it ?

Ecore_X_Window focusedWindow = ecore_x_window_focus_get();

[Grzegorz Czajkowski]

Created attachment 240008 [details]
Patch for landing

[Grzegorz Czajkowski]

(In reply to comment #3)
> Comment on attachment 239948 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=239948&action=review
> 
> > Source/WebCore/platform/efl/PlatformScreenEfl.cpp:94
> > +    if (ecore_x_randr_query() && ecore_x_window_focus_get())
> 
> ecore_x_window_focus_get() is called twice. How about using a variable to
> handle it ?
> 
> Ecore_X_Window focusedWindow = ecore_x_window_focus_get();

Nice catch! Fixed.

[WebKit Commit Bot]

Comment on attachment 240008 [details]
Patch for landing

Clearing flags on attachment: 240008

Committed r174819: <http://trac.webkit.org/changeset/174819>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.