Bug 137774 – Fix FTL Native Inlining for EFL

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Dániel Bátyai]

Fix FTL Native Inlining for EFL

[Dániel Bátyai]

Created attachment 239940 [details]
Patch

Initial WIP. 
Added required functionality and updated CMake to generate the required bitcode.
There is a small issue with the script generating InlineRuntmeSymbolTable.h, 
but overall the inlining is working correctly.

[Dániel Bátyai]

Created attachment 239943 [details]
Patch

Added missing files

[WebKit Commit Bot]

Attachment 239943 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/CMakeLists.txt:795:  There should be exactly one empty line instead of 0 between "inspector" and "inspector/agents".  [list/emptyline] [5]
ERROR: Source/JavaScriptCore/CMakeLists.txt:797:  Alphabetical sorting problem. "interpreter" should be before "inspector/remote".  [list/order] [5]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Michael Saboff]

Comment on attachment 239943 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 239943 [details]
Patch

Clearing flags on attachment: 239943

Committed r174940: <http://trac.webkit.org/changeset/174940>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Ting-Wei Lan]

This patch causes compilation error on FreeBSD 10.1. program_invocation_name is a GNU extension, so it should not be used unconditionally.

Source/JavaScriptCore/runtime/BundlePath.cpp:41:42: error: use of undeclared identifier 'program_invocation_name'
        std::string programPath(realpath(program_invocation_name, 0));
                                         ^
1 error generated.

[Tibor Mészáros]

(In reply to comment #7)
> This patch causes compilation error on FreeBSD 10.1. program_invocation_name
> is a GNU extension, so it should not be used unconditionally.
> 
> Source/JavaScriptCore/runtime/BundlePath.cpp:41:42: error: use of undeclared
> identifier 'program_invocation_name'
>         std::string programPath(realpath(program_invocation_name, 0));
>                                          ^
> 1 error generated.

Hi Ting-Wei Lan!

https://bugs.webkit.org/show_bug.cgi?id=137924 will fix this problem.