RESOLVED FIXED 137771
CSS JIT: Introduce addressToStackReference 
https://bugs.webkit.org/show_bug.cgi?id=137771
Summary CSS JIT: Introduce addressToStackReference
Yusuke Suzuki
Reported 2014-10-15 23:50:55 PDT
CSS JIT: Introduce addressToStackReference
Attachments
Patch (10.08 KB, patch)
2014-10-15 23:53 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (10.08 KB, patch)
2014-10-16 00:15 PDT, Yusuke Suzuki 		benjamin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2014-10-15 23:53:43 PDT
Created attachment 239934 [details] Patch
Yusuke Suzuki
Comment 2 2014-10-16 00:15:33 PDT
Created attachment 239938 [details] Patch
Benjamin Poulain
Comment 3 2014-10-16 21:27:07 PDT
Comment on attachment 239938 [details] Patch That's a great idea, this cleans up the code and make it harder to misuse the stack. I think the name addressToStackReference can be confusing. What do you think of: -stackReferenceAddress() -addressOfStackReference() or simply -addressOf(StackReference)
Yusuke Suzuki
Comment 4 2014-10-16 22:09:01 PDT
(In reply to comment #3) > Comment on attachment 239938 [details] > Patch > > That's a great idea, this cleans up the code and make it harder to misuse > the stack. > > I think the name addressToStackReference can be confusing. What do you think > of: > -stackReferenceAddress() > -addressOfStackReference() > or simply > -addressOf(StackReference) `addressOf` looks very nice :), its name and parameter's type describes the role of the function clearly. I'll apply this change and land the patch.
Yusuke Suzuki
Comment 5 2014-10-16 22:17:49 PDT
Committed r174810: <http://trac.webkit.org/changeset/174810>
Note You need to log in before you can comment on or make changes to this bug.