Bug 137757 – REGRESSION(r171593) [Mac] Media controls create a large (and unnecessary) backing store

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[Mac] Controls create a large (and unnecessary) backing store

[Jer Noble]

Regressed in <http://trac.webkit.org/r171593>.

[Jer Noble]

Created attachment 239906 [details]
Patch

[Jer Noble]

Created attachment 239907 [details]
Patch

[Eric Carlson]

Comment on attachment 239907 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239907&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:142
> +

Nit: extra blank line

[Build Bot]

Comment on attachment 239907 [details]
Patch

Attachment 239907 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5130244105175040

New failing tests:
media/video-no-audio.html
media/controls-strict.html
media/video-volume-slider.html
media/video-display-toggle.html
media/audio-controls-rendering.html
media/video-zoom-controls.html
media/video-controls-rendering.html
media/controls-without-preload.html
media/video-empty-source.html

[Build Bot]

Created attachment 239910 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 239907 [details]
Patch

Attachment 239907 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6327367454687232

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 239919 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Jer Noble]

Created attachment 239920 [details]
Patch for landing

[Alexey Proskuryakov]

Comment on attachment 239920 [details]
Patch for landing

Please don't land as is, EWS is seeing errors.

Filed bug 137892 to make EWS smarter in this particular case.

Unexpected text-only failures (10)
  media/audio-controls-rendering.html [ Failure ]
  media/controls-after-reload.html [ Failure ]
  media/controls-strict.html [ Failure ]
  media/controls-styling.html [ Failure ]
  media/controls-without-preload.html [ Failure ]
  media/video-controls-rendering.html [ Failure ]
  media/video-display-toggle.html [ Failure ]
  media/video-no-audio.html [ Failure ]
  media/video-volume-slider.html [ Failure ]
  media/video-zoom-controls.html [ Failure ]

[Jer Noble]

(In reply to comment #10)
> Comment on attachment 239920 [details]
> Patch for landing
> 
> Please don't land as is, EWS is seeing errors.


Don't worry, I'm trying to fix these all before landing.

[Jer Noble]

Created attachment 240557 [details]
Patch for landing

Rebaselined Yosemite and Mavericks results separately.

[Jon Lee]

rdar://problem/18195906

[Jer Noble]

Committed r175268: <http://trac.webkit.org/changeset/175268>

[Jer Noble]

Removed the unintentional extra *-diff.html results from the last patch before landing.