Bug 137757 - REGRESSION(r171593) [Mac] Media controls create a large (and unnecessary) backing store
Summary: REGRESSION(r171593) [Mac] Media controls create a large (and unnecessary) bac...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-10-15 16:10 PDT by Jer Noble
Modified: 2014-10-28 12:38 PDT (History)
11 users (show)

See Also:


Attachments
Patch (17.10 KB, patch)
2014-10-15 16:38 PDT, Jer Noble
no flags Details | Formatted Diff | Diff
Patch (16.67 KB, patch)
2014-10-15 16:48 PDT, Jer Noble
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (860.01 KB, application/zip)
2014-10-15 17:55 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (615.36 KB, application/zip)
2014-10-15 19:35 PDT, Build Bot
no flags Details
Patch for landing (1.73 MB, patch)
2014-10-15 19:43 PDT, Jer Noble
ap: review-
Details | Formatted Diff | Diff
Patch for landing (1.01 MB, patch)
2014-10-28 10:54 PDT, Jer Noble
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-10-15 16:10:58 PDT
[Mac] Controls create a large (and unnecessary) backing store
Comment 1 Jer Noble 2014-10-15 16:12:57 PDT
Regressed in <http://trac.webkit.org/r171593>.
Comment 2 Jer Noble 2014-10-15 16:38:22 PDT
Created attachment 239906 [details]
Patch
Comment 3 Jer Noble 2014-10-15 16:48:47 PDT
Created attachment 239907 [details]
Patch
Comment 4 Eric Carlson 2014-10-15 17:01:04 PDT
Comment on attachment 239907 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239907&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.js:142
> +

Nit: extra blank line
Comment 5 Build Bot 2014-10-15 17:55:22 PDT
Comment on attachment 239907 [details]
Patch

Attachment 239907 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5130244105175040

New failing tests:
media/video-no-audio.html
media/controls-strict.html
media/video-volume-slider.html
media/video-display-toggle.html
media/audio-controls-rendering.html
media/video-zoom-controls.html
media/video-controls-rendering.html
media/controls-without-preload.html
media/video-empty-source.html
Comment 6 Build Bot 2014-10-15 17:55:25 PDT
Created attachment 239910 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 7 Build Bot 2014-10-15 19:35:08 PDT
Comment on attachment 239907 [details]
Patch

Attachment 239907 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6327367454687232

Number of test failures exceeded the failure limit.
Comment 8 Build Bot 2014-10-15 19:35:13 PDT
Created attachment 239919 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 9 Jer Noble 2014-10-15 19:43:41 PDT
Created attachment 239920 [details]
Patch for landing
Comment 10 Alexey Proskuryakov 2014-10-20 13:06:47 PDT
Comment on attachment 239920 [details]
Patch for landing

Please don't land as is, EWS is seeing errors.

Filed bug 137892 to make EWS smarter in this particular case.

Unexpected text-only failures (10)
  media/audio-controls-rendering.html [ Failure ]
  media/controls-after-reload.html [ Failure ]
  media/controls-strict.html [ Failure ]
  media/controls-styling.html [ Failure ]
  media/controls-without-preload.html [ Failure ]
  media/video-controls-rendering.html [ Failure ]
  media/video-display-toggle.html [ Failure ]
  media/video-no-audio.html [ Failure ]
  media/video-volume-slider.html [ Failure ]
  media/video-zoom-controls.html [ Failure ]
Comment 11 Jer Noble 2014-10-20 13:22:22 PDT
(In reply to comment #10)
> Comment on attachment 239920 [details]
> Patch for landing
> 
> Please don't land as is, EWS is seeing errors.


Don't worry, I'm trying to fix these all before landing.
Comment 12 Jer Noble 2014-10-28 10:54:20 PDT
Created attachment 240557 [details]
Patch for landing

Rebaselined Yosemite and Mavericks results separately.
Comment 13 Jon Lee 2014-10-28 11:50:14 PDT
rdar://problem/18195906
Comment 14 Jer Noble 2014-10-28 12:37:26 PDT
Committed r175268: <http://trac.webkit.org/changeset/175268>
Comment 15 Jer Noble 2014-10-28 12:38:14 PDT
Removed the unintentional extra *-diff.html results from the last patch before landing.