Bug 137753 - Web Inspector: InspectorBackendCommands should include when to activate particular domains
Summary: Web Inspector: InspectorBackendCommands should include when to activate parti...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-10-15 14:08 PDT by Joseph Pecoraro
Modified: 2014-10-20 13:45 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (62.45 KB, patch)
2014-10-17 12:07 PDT, Joseph Pecoraro 		timothy: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-10-15 14:08:44 PDT 
For JS debuggables, only some domains are active by default. For Web debuggables, all domains are active. This logic should be generated into the BackendCommands.
Comment 1 Radar WebKit Bug Importer 2014-10-15 14:09:09 PDT 
<rdar://problem/18669637>
Comment 2 Radar WebKit Bug Importer 2014-10-15 14:09:11 PDT 
<rdar://problem/18669638>
Comment 3 Joseph Pecoraro 2014-10-17 12:07:24 PDT 
Created attachment 240029 [details]
[PATCH] Proposed Fix

Depends on bug 137748.
Comment 4 Timothy Hatcher 2014-10-18 01:07:51 PDT 
Comment on attachment 240029 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=240029&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        Add an activate property to domains that only activate for

The property name "activate" reads funny since it is a verb. I expect only nouns for that purpose. Maybe "availability"? And since "js" isn't allowed, only "web", maybe "extendedAvailability"?

Otherwise the patch looks good.
Comment 5 Joseph Pecoraro 2014-10-20 11:01:38 PDT 
I like availability.
Comment 6 Joseph Pecoraro 2014-10-20 13:45:28 PDT 
http://trac.webkit.org/changeset/174906