When you create a rendering context with alpha:false, this means that the context returned should be opaque.
However, with nvidia cards, calling glreadpixels on such contexts returns the wrong value. It returns 0's in the alpha channel, they should be 255 instead.
As a workaround for this, after calls to ::glReadPixels we should manually set the alpha channel to 255 if alpha is off for the context.
I believe this is the last failing 1.0.2 test on at least the 2 nvidia cards i've tested on. (the 9600M GT and the 750 M)
Created attachment 239892 [details]
Comment on attachment 239892 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=239892&action=review
Looks good. Could you please mention the two failing tests that you have fixed with this change? Thanks.
> + Reviewed by NOBODY (OOPS!).
Can you list the two failing tests that were fixed by this?
Committed with mention of fixed test in changelog.
Re-opened since this is blocked by bug 137790
Closing this since I filed another bug for the issue.
*** This bug has been marked as a duplicate of bug 137793 ***