RESOLVED FIXED 137741
Removing CUSTOM_PROTOCOLS guard 
https://bugs.webkit.org/show_bug.cgi?id=137741
Summary Removing CUSTOM_PROTOCOLS guard
Pascal Jacquemart
Reported 2014-10-15 07:40:41 PDT
CUSTOM_PROTOCOLS is the default code path for all ports now since r174419 [EFL] "Enable custom URI schemes with CustomProtocols" It is not a real feature since the flag is hard-coded (WebKit2Prefix.h for Mac and GTK / OptionsEfl.cmake for EFL) Most ports won't compile without this flag (at least GTK and EFL). Also this CUSTOM_PROTOCOLS naming can be confusing against another real feature called CUSTOM_SCHEME_HANDLER
Attachments
Removing CUSTOM_PROTOCOLS guard (34.55 KB, patch)
2014-10-15 07:46 PDT, Pascal Jacquemart 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pascal Jacquemart
Comment 1 2014-10-15 07:46:01 PDT
Created attachment 239872 [details] Removing CUSTOM_PROTOCOLS guard
Darin Adler
Comment 2 2014-10-15 09:14:46 PDT
I don’t see any reason to wait. Seems like we should land this. Any objections?
Anders Carlsson
Comment 3 2014-10-15 09:18:34 PDT
(In reply to comment #2) > I don’t see any reason to wait. Seems like we should land this. Any objections? Nope, let's do it.
WebKit Commit Bot
Comment 4 2014-10-16 18:14:29 PDT
Comment on attachment 239872 [details] Removing CUSTOM_PROTOCOLS guard Clearing flags on attachment: 239872 Committed r174803: <http://trac.webkit.org/changeset/174803>
WebKit Commit Bot
Comment 5 2014-10-16 18:14:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.