Bug 137741 - Removing CUSTOM_PROTOCOLS guard
Summary: Removing CUSTOM_PROTOCOLS guard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-15 07:40 PDT by Pascal Jacquemart
Modified: 2014-10-16 18:14 PDT (History)
8 users (show)

See Also:

Attachments
Removing CUSTOM_PROTOCOLS guard (34.55 KB, patch)
2014-10-15 07:46 PDT, Pascal Jacquemart 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Jacquemart 2014-10-15 07:40:41 PDT 
CUSTOM_PROTOCOLS is the default code path for all ports now since r174419 [EFL] "Enable custom URI schemes with CustomProtocols"

It is not a real feature since the flag is hard-coded (WebKit2Prefix.h for Mac and GTK / OptionsEfl.cmake for EFL)
Most ports won't compile without this flag (at least GTK and EFL). 

Also this CUSTOM_PROTOCOLS naming can be confusing against another real feature called CUSTOM_SCHEME_HANDLER
Comment 1 Pascal Jacquemart 2014-10-15 07:46:01 PDT 
Created attachment 239872 [details]
Removing CUSTOM_PROTOCOLS guard
Comment 2 Darin Adler 2014-10-15 09:14:46 PDT 
I don’t see any reason to wait. Seems like we should land this. Any objections?
Comment 3 Anders Carlsson 2014-10-15 09:18:34 PDT 
(In reply to comment #2)
> I don’t see any reason to wait. Seems like we should land this. Any objections?

Nope, let's do it.
Comment 4 WebKit Commit Bot 2014-10-16 18:14:29 PDT 
Comment on attachment 239872 [details]
Removing CUSTOM_PROTOCOLS guard

Clearing flags on attachment: 239872

Committed r174803: <http://trac.webkit.org/changeset/174803>
Comment 5 WebKit Commit Bot 2014-10-16 18:14:41 PDT 
All reviewed patches have been landed.  Closing bug.