WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
137737
[ATK] Improve AccessibilityTableCell determineAccessibilityRole function.
https://bugs.webkit.org/show_bug.cgi?id=137737
Summary
[ATK] Improve AccessibilityTableCell determineAccessibilityRole function.
Andrzej Badowski
Reported
2014-10-15 02:28:06 PDT
Use of new functions isRowHeaderCell and isColumnHeaderCell (
bug 136818
) to more accurately determine accessibility role of the table cell.
Attachments
proposed patch
(23.46 KB, patch)
2014-10-21 07:10 PDT
,
Andrzej Badowski
no flags
Details
Formatted Diff
Diff
proposed patch 2
(23.57 KB, patch)
2014-10-21 07:52 PDT
,
Andrzej Badowski
cfleizach
: review+
Details
Formatted Diff
Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2
(491.41 KB, application/zip)
2014-10-23 19:56 PDT
,
Build Bot
no flags
Details
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion
(669.58 KB, application/zip)
2014-10-23 20:28 PDT
,
Build Bot
no flags
Details
proposed patch 3
(24.20 KB, patch)
2014-10-27 01:58 PDT
,
Andrzej Badowski
g.czajkowski
: commit-queue+
Details
Formatted Diff
Diff
proposed patch 4
(24.15 KB, patch)
2014-10-30 05:41 PDT
,
Andrzej Badowski
no flags
Details
Formatted Diff
Diff
proposed patch 5
(24.15 KB, patch)
2014-10-30 05:49 PDT
,
Andrzej Badowski
no flags
Details
Formatted Diff
Diff
Show Obsolete
(4)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2014-10-15 02:28:32 PDT
<
rdar://problem/18662321
>
Andrzej Badowski
Comment 2
2014-10-21 07:10:13 PDT
Created
attachment 240201
[details]
proposed patch
WebKit Commit Bot
Comment 3
2014-10-21 07:11:28 PDT
Attachment 240201
[details]
did not pass style-queue: ERROR: LayoutTests/ChangeLog:20: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Total errors found: 1 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andrzej Badowski
Comment 4
2014-10-21 07:52:40 PDT
Created
attachment 240203
[details]
proposed patch 2
Andrzej Badowski
Comment 5
2014-10-22 01:08:55 PDT
I will check results of tests on Mac
Build Bot
Comment 6
2014-10-23 19:56:33 PDT
Created
attachment 240384
[details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Build Bot
Comment 7
2014-10-23 20:28:13 PDT
Created
attachment 240386
[details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Andrzej Badowski
Comment 8
2014-10-27 01:58:45 PDT
Created
attachment 240472
[details]
proposed patch 3
Andrzej Badowski
Comment 9
2014-10-30 05:41:01 PDT
Created
attachment 240668
[details]
proposed patch 4
WebKit Commit Bot
Comment 10
2014-10-30 05:44:03 PDT
Attachment 240668
[details]
did not pass style-queue: ERROR: LayoutTests/platform/mac/TestExpectations:1076: expecting "[", "#", or end of line instead of "accessibility/table-cells-roles.html" [test/expectations] [5] ERROR: LayoutTests/platform/mac/TestExpectations:1076: Path does not exist. [test/expectations] [5] Total errors found: 2 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andrzej Badowski
Comment 11
2014-10-30 05:49:56 PDT
Created
attachment 240669
[details]
proposed patch 5
WebKit Commit Bot
Comment 12
2014-10-31 05:45:52 PDT
Comment on
attachment 240669
[details]
proposed patch 5 Clearing flags on attachment: 240669 Committed
r175408
: <
http://trac.webkit.org/changeset/175408
>
WebKit Commit Bot
Comment 13
2014-10-31 05:45:55 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug