Bug 137735 – [GTK] Move touch events handling from Platform to WebKit2

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Carlos Garcia Campos]

GtkTouchContextHelper is only used by WebKitWebViewBase, since it's the only one that can create touch events. The code can be simplified if the events are processed in the view, and the native touch events are created with the native event and touch points.

[Carlos Garcia Campos]

Created attachment 239857 [details]
Patch

[WebKit Commit Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Sergio Villar Senin]

Comment on attachment 239857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239857&action=review

Another file nuked yay!

Everything seems to be right, it's a r+ for me, but consider my suggestions before landing.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:806
> +static void webkitWebViewBaseGetTouchPointForEvent(WebKitWebViewBase* webViewBase, GdkEvent* event, Vector<WebPlatformTouchPoint>& touchPoints)

Nit: GetTouchPoints

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:811
> +    for (auto it = priv->touchEvents.begin(); it != priv->touchEvents.end(); ++it) {

You can use a modern for loop here.

for (auto& touchEvent : priv->touchEvents)

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:828
> +    }

I am not sure a lambda is appropriate here, for me it seems far more confusing than calling a function.

[Carlos Garcia Campos]

Committed r174817: <http://trac.webkit.org/changeset/174817>