Bug 137722 - Use is<>() / downcast<>() for PlatformCAAnimation subclasses
Summary: Use is<>() / downcast<>() for PlatformCAAnimation subclasses
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 137056
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-14 15:39 PDT by Chris Dumez
Modified: 2014-10-14 17:41 PDT (History)
2 users (show)

See Also:

Attachments
Patch (49.51 KB, patch)
2014-10-14 16:14 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (49.45 KB, patch)
2014-10-14 16:58 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-10-14 15:39:57 PDT 
Use is<>() / downcast<>() for PlatformCAAnimation subclasses.
Comment 1 Chris Dumez 2014-10-14 16:14:35 PDT 
Created attachment 239830 [details]
Patch
Comment 2 WebKit Commit Bot 2014-10-14 16:16:34 PDT 
Attachment 239830 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/ca/win/PlatformCAAnimationWin.cpp:435:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm:398:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm:455:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm:541:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 4 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2014-10-14 16:58:01 PDT 
Created attachment 239834 [details]
Patch
Comment 4 WebKit Commit Bot 2014-10-14 17:00:18 PDT 
Attachment 239834 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/ca/win/PlatformCAAnimationWin.cpp:435:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm:398:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm:455:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm:541:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 4 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Commit Bot 2014-10-14 17:41:02 PDT 
Comment on attachment 239834 [details]
Patch

Clearing flags on attachment: 239834

Committed r174715: <http://trac.webkit.org/changeset/174715>
Comment 6 WebKit Commit Bot 2014-10-14 17:41:06 PDT 
All reviewed patches have been landed.  Closing bug.