Bug 137678 - Web Inspector: Remove unused stale Page protocol methods
Summary: Web Inspector: Remove unused stale Page protocol methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-10-13 16:39 PDT by Joseph Pecoraro
Modified: 2014-10-13 18:30 PDT (History)
5 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (13.38 KB, patch)
2014-10-13 16:42 PDT, Joseph Pecoraro
kling: review+
Details | Formatted Diff | Diff
[PATCH] Proposed Fix (17.39 KB, patch)
2014-10-13 17:30 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-10-13 16:39:42 PDT
We have a number of unused, stale, Page protocol methods:

  - canShowDebugBorders
  - setShowDebugBorders
  - canShowFPSCounter
  - setShowFPSCounter
  - canContinuouslyPaint
  - setContinuousPaintingEnabled

Lets remove these as they are unimplemented. We can implement and add them in the future.
Comment 1 Radar WebKit Bug Importer 2014-10-13 16:39:52 PDT
<rdar://problem/18641666>
Comment 2 Joseph Pecoraro 2014-10-13 16:42:38 PDT
Created attachment 239758 [details]
[PATCH] Proposed Fix
Comment 3 Andreas Kling 2014-10-13 16:53:47 PDT
Comment on attachment 239758 [details]
[PATCH] Proposed Fix

r=me
Comment 4 Joseph Pecoraro 2014-10-13 17:30:49 PDT
Created attachment 239765 [details]
[PATCH] Proposed Fix
Comment 5 WebKit Commit Bot 2014-10-13 18:30:10 PDT
Comment on attachment 239765 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 239765

Committed r174668: <http://trac.webkit.org/changeset/174668>
Comment 6 WebKit Commit Bot 2014-10-13 18:30:13 PDT
All reviewed patches have been landed.  Closing bug.