Bug 137674 - Improve the test image diffs page
Summary: Improve the test image diffs page
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-13 14:59 PDT by Simon Fraser (smfr)
Modified: 2014-10-13 15:45 PDT (History)
6 users (show)

See Also:

Attachments
Patch (9.72 KB, patch)
2014-10-13 15:01 PDT, Simon Fraser (smfr) 		ap: review+
Details | Formatted Diff | Diff
Example (4.65 KB, text/html)
2014-10-13 15:05 PDT, Simon Fraser (smfr) 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-10-13 14:59:56 PDT 
Improve the test image diffs page
Comment 1 Simon Fraser (smfr) 2014-10-13 15:01:52 PDT 
Created attachment 239749 [details]
Patch
Comment 2 WebKit Commit Bot 2014-10-13 15:04:32 PDT 
Attachment 239749 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:178:  multiple statements on one line (semicolon)  [pep8/E702] [5]
ERROR: Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:179:  multiple statements on one line (semicolon)  [pep8/E702] [5]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2014-10-13 15:05:07 PDT 
Created attachment 239750 [details]
Example
Comment 4 Alexey Proskuryakov 2014-10-13 15:24:29 PDT 
Comment on attachment 239749 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239749&action=review

> LayoutTests/fast/harness/image-diff-template.html:91
> +    ++preloadedImageCount;
> +    if (preloadedImageCount < 2)
> +        return;

This is old code, but I don't understand why 2 is the right value here. We are preloading 3 images.

> LayoutTests/fast/harness/image-diff-template.html:160
> +        cycleIntervalID = 0;

Could be undefined to match initial value.
Comment 5 Simon Fraser (smfr) 2014-10-13 15:45:07 PDT 
https://trac.webkit.org/r174662