WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
137656
[GTK][CMake] Non-ninja build is broken since
r174422
https://bugs.webkit.org/show_bug.cgi?id=137656
Summary
[GTK][CMake] Non-ninja build is broken since r174422
Carlos Garcia Campos
Reported
2014-10-13 05:26:17 PDT
For some reason CMake doesn't know how to generate DerivedSources/WebInspectorUI/UserInterface/Protocol/InspectorJSBackendCommands.js. The rule is there and it works when using ninja. It even fails if JavaScriptCore is built before and the file is already generated. make[2]: *** No rule to make target 'DerivedSources/WebInspectorUI/UserInterface/Protocol/InspectorJSBackendCommands.js', needed by 'DerivedSources/webkit2gtk/InspectorGResourceBundle.xml'. Alto. [ 1%] [ 1%] CMakeFiles/Makefile2:986: recipe for target 'Source/WebKit2/CMakeFiles/WebKit2-forwarding-headers.dir/all' failed make[1]: *** [Source/WebKit2/CMakeFiles/WebKit2-forwarding-headers.dir/all] Error 2
Attachments
Patch
(2.79 KB, patch)
2014-10-13 05:29 PDT
,
Carlos Garcia Campos
pnormand
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2014-10-13 05:29:28 PDT
Created
attachment 239723
[details]
Patch Making the forwarding headers generation rule not depend on generated sources seems to fix the problem
Sergio Villar Senin
Comment 2
2014-10-13 06:13:55 PDT
Comment on
attachment 239723
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=239723&action=review
Do not have enough knowledge to review this...
> Source/WebKit2/ChangeLog:3 > + [GTK][CMake] Non-nonja build is broken since
r174422
Nit: ninja
Carlos Garcia Campos
Comment 3
2014-10-13 06:16:14 PDT
(In reply to
comment #2
)
> (From update of
attachment 239723
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=239723&action=review
> > Do not have enough knowledge to review this... > > > Source/WebKit2/ChangeLog:3 > > + [GTK][CMake] Non-nonja build is broken since
r174422
> > Nit: ninja
Oops
Carlos Garcia Campos
Comment 4
2014-10-13 23:58:31 PDT
Committed
r174671
: <
http://trac.webkit.org/changeset/174671
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug