Bug 137656 – [GTK][CMake] Non-ninja build is broken since r174422

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

For some reason CMake doesn't know how to generate DerivedSources/WebInspectorUI/UserInterface/Protocol/InspectorJSBackendCommands.js. The rule is there and it works when using ninja. It even fails if JavaScriptCore is built before and the file is already generated. 

make[2]: *** No rule to make target 'DerivedSources/WebInspectorUI/UserInterface/Protocol/InspectorJSBackendCommands.js', needed by 'DerivedSources/webkit2gtk/InspectorGResourceBundle.xml'.  Alto.
[  1%] [  1%] CMakeFiles/Makefile2:986: recipe for target 'Source/WebKit2/CMakeFiles/WebKit2-forwarding-headers.dir/all' failed
make[1]: *** [Source/WebKit2/CMakeFiles/WebKit2-forwarding-headers.dir/all] Error 2

[Carlos Garcia Campos]

Created attachment 239723 [details]
Patch

Making the forwarding headers generation rule not depend on generated sources seems to fix the problem

[Sergio Villar Senin]

Comment on attachment 239723 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239723&action=review

Do not have enough knowledge to review this...

> Source/WebKit2/ChangeLog:3
> +        [GTK][CMake] Non-nonja build is broken since r174422

Nit: ninja

[Carlos Garcia Campos]

(In reply to comment #2)
> (From update of attachment 239723 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=239723&action=review
> 
> Do not have enough knowledge to review this...
> 
> > Source/WebKit2/ChangeLog:3
> > +        [GTK][CMake] Non-nonja build is broken since r174422
> 
> Nit: ninja

Oops

[Carlos Garcia Campos]

Committed r174671: <http://trac.webkit.org/changeset/174671>