Bug 137650 - iOS DRT snapshots are limited to the page visible area
Summary: iOS DRT snapshots are limited to the page visible area
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-12 12:41 PDT by Simon Fraser (smfr)
Modified: 2014-12-11 15:26 PST (History)
5 users (show)

See Also:

Attachments
Patch (6.18 KB, patch)
2014-10-12 12:44 PDT, Simon Fraser (smfr) 		dbates: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-10-12 12:41:49 PDT 
iOS DRT snapshots are limited to the page visible area
Comment 1 Simon Fraser (smfr) 2014-10-12 12:44:38 PDT 
Created attachment 239707 [details]
Patch
Comment 2 David Farler 2014-10-12 13:06:42 PDT 
Are we OK to keep the iPhone models as the default then?
Comment 3 Simon Fraser (smfr) 2014-10-12 13:29:53 PDT 
I wasn't able to successfully get iPad Air models working. Even if I did, we'd have to do rotation to get the entire 800x600, so I think this is simpler.
Comment 4 Daniel Bates 2014-10-12 23:13:40 PDT 
Comment on attachment 239707 [details]
Patch

This looks sane to me. Does this patch resolve or help us resolve <rdar://problem/14637393>?
Comment 5 WebKit Commit Bot 2014-10-13 15:18:59 PDT 
Comment on attachment 239707 [details]
Patch

Rejecting attachment 239707 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 239707, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
portIOS.mm
Hunk #1 FAILED at 60.
Hunk #2 FAILED at 76.
2 out of 2 hunks FAILED -- saving rejects to file Tools/DumpRenderTree/ios/PixelDumpSupportIOS.mm.rej
patching file Tools/DumpRenderTree/mac/DumpRenderTreeWindow.mm
Hunk #1 FAILED at 81.
1 out of 1 hunk FAILED -- saving rejects to file Tools/DumpRenderTree/mac/DumpRenderTreeWindow.mm.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Daniel Bates']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/4676569930924032
Comment 6 Simon Fraser (smfr) 2014-12-11 15:26:43 PST 
http://trac.webkit.org/changeset/174650