Bug 137640 – [GTK] fails to build with --disable-accelerated-compositing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alexander Tsoy]

Created attachment 239685 [details]
Fix compilation with --disable-accelerated-compositing

This problem was introduced in changeset <http://trac.webkit.org/changeset/172828>. The attached patch makes compilation process go further until I get the same linkage error as in bug 131267. I can attach the full build log if necessary.

The actual error:

Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp: In member function ‘void WebKit::WebProcess::platformSetCacheModel(WebKit::CacheModel)’:
Source/WebKit2/WebProcess/soup/WebProcessSoup.cpp:114:27: error: ‘class WebCore::PageCache’ has no member named ‘setShouldClearBackingStores’
     WebCore::pageCache()->setShouldClearBackingStores(true);
                           ^
GNUmakefile:75880: recipe for target 'Source/WebKit2/WebProcess/soup/libwebkit2gtk_3_0_la-WebProcessSoup.lo' failed

[Alexander Tsoy]

(In reply to comment #0)

> The attached patch makes compilation process go further until I get the same linkage error as in bug 131267.

Linkage error was caused by --disable-webgl. I already provided a patch for that issue in bug 131267. Ignore it in this bug report.

[Zan Dobersek]

What specific version of WebKitGTK+?

[Alexander Tsoy]

2.4.6 and 2.4.7

[Alberto Garcia]

Yes, this should go to the 2.4 branch, I just tested it.

[Carlos Garcia Campos]

Committed to 2.4 http://trac.webkit.org/changeset/184467. Thanks