RESOLVED FIXED 137624
Web Inspector: CSS minification should not strip whitespace around calc +/- binary operators 
https://bugs.webkit.org/show_bug.cgi?id=137624
Summary Web Inspector: CSS minification should not strip whitespace around calc +/- b...
Joseph Pecoraro
Reported 2014-10-10 14:18:47 PDT
In production, minified builds we see a warning in our Main.css: [Warning] Unexpected CSS token: ) See also: <https://webkit.org/b/137620> Web Inspector: Poor CSS warning message with missing spaces in calc() +/- operation
Attachments
[PATCH] Proposed Fix (3.34 KB, patch)
2014-10-10 14:30 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-10-10 14:19:14 PDT
<rdar://problem/18615543>
Joseph Pecoraro
Comment 2 2014-10-10 14:30:40 PDT
Created attachment 239648 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 3 2014-10-10 14:32:02 PDT
Attachment 239648 [details] did not pass style-queue: ERROR: Source/WebInspectorUI/Scripts/cssmin.py:33: at least two spaces before inline comment [pep8/E261] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Timothy Hatcher
Comment 4 2014-10-10 15:00:51 PDT
Comment on attachment 239648 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=239648&action=review > Source/WebInspectorUI/ChangeLog:15 > + * Scripts/copy-user-interface-resources-dryrun.rb: Added. Yay!
WebKit Commit Bot
Comment 5 2014-10-10 15:38:39 PDT
Comment on attachment 239648 [details] [PATCH] Proposed Fix Clearing flags on attachment: 239648 Committed r174615: <http://trac.webkit.org/changeset/174615>
WebKit Commit Bot
Comment 6 2014-10-10 15:38:42 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 7 2014-10-10 15:49:39 PDT
This fixed the appearance of alpha color swatches in production builds.
Note You need to log in before you can comment on or make changes to this bug.