Bug 137611 - Multiple refactors in RenderMathMLOperator
Summary: Multiple refactors in RenderMathMLOperator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-10 07:26 PDT by Alejandro G. Castro
Modified: 2014-10-14 03:06 PDT (History)
1 user (show)

See Also:


Attachments
patch (22.88 KB, patch)
2014-10-10 07:41 PDT, Alejandro G. Castro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alejandro G. Castro 2014-10-10 07:26:58 PDT
Clean the code in RenderMathMLOperator following suggestions in bug #136883.
Comment 1 Alejandro G. Castro 2014-10-10 07:41:30 PDT
Created attachment 239624 [details]
patch
Comment 2 Alejandro G. Castro 2014-10-10 07:58:42 PDT
The patch applies over the patch in bug #133845.
Comment 3 Darin Adler 2014-10-10 09:41:25 PDT
Comment on attachment 239624 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239624&action=review

> Source/WebCore/ChangeLog:9
> +        - Make most of the functions private, we needed to create some API
> +        and move trailingSpaceError to RenderMathMLOperator.

To be pedantic, the new member functions are needed because of making data members private, not functions. Also, I personally wouldn't use the term API to mean public functions here; there’s no “app”.
Comment 4 Alejandro G. Castro 2014-10-14 02:59:35 PDT
(In reply to comment #3)
> (From update of attachment 239624 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=239624&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        - Make most of the functions private, we needed to create some API
> > +        and move trailingSpaceError to RenderMathMLOperator.
> 
> To be pedantic, the new member functions are needed because of making data members private, not functions. Also, I personally wouldn't use the term API to mean public functions here; there’s no “app”.

I'll fix that, thanks :).
Comment 5 Alejandro G. Castro 2014-10-14 03:06:19 PDT
Landed http://trac.webkit.org/changeset/174678

Thanks!