Bug 137607 - Add tiny version to generate-webkitversion.pl
Summary: Add tiny version to generate-webkitversion.pl
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-10 04:38 PDT by Adrien Destugues
Modified: 2016-09-17 07:05 PDT (History)
0 users

See Also:

Attachments
Patch (2.26 KB, patch)
2014-10-10 04:40 PDT, Adrien Destugues 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrien Destugues 2014-10-10 04:38:07 PDT 
Add tiny version to generate-webkitversion.pl
Comment 1 Adrien Destugues 2014-10-10 04:40:56 PDT 
Created attachment 239618 [details]
Patch
Comment 2 Alexey Proskuryakov 2014-10-10 09:36:44 PDT 
Comment on attachment 239618 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239618&action=review

> Source/WebKit/ChangeLog:8
> +        WebKit version now has a third "tiny" number. Extract it from the

This explains what the patch does, but not why. Can you share the reasons why such a macro is necessary?
Comment 3 Adrien Destugues 2014-10-10 09:57:10 PDT 
The Haiku port of WebKit shows the tiny verson in the about box to help identifying which version of WebKit is used. The mjor/minor versions don't change often enough to be useful for that.
Comment 4 Michael Catanzaro 2016-09-17 07:05:00 PDT 
Comment on attachment 239618 [details]
Patch

Hi,

Apologies that your patch was not reviewed in a timely manner. Since it's now quite old, I am removing it from the review request queue. Please consider rebasing it on trunk and resubmitting.

To increase the chances of getting a review, consider using 'Tools/Scripts/webkit-patch upload --suggest-reviewers' to CC reviewers who might be interested in this bug.