Bug 137602 – Add test to check stretchy value is case sensitive

• Status: RESOLVED
• Resolution: FIXED
• Component: MathML

[Alejandro G. Castro]

It is not usual for other specs so it is good we have a test checking the sensitiveness of the attribute. This is a followup of the bug #136883.

[Alejandro G. Castro]

Created attachment 239611 [details]
patch

[Darin Adler]

Comment on attachment 239611 [details]
patch

Two thoughts:

1) We should also check that "false" is case sensitive. I presume there is some case where the default for stretchy is true, and "false" changes it back to false, but "False" does not.

2) Tests that explain what the results should look like are generally better than tests that don't. Even though this is a reference test it would be nice if it was self-explanatory in the browser. In many cases I put expected results in the original as well as the expected file so a human being can compare things visually, and then put the expected result twice in the expected.html file. For example, fast/text/international/old-turkic-direction.html takes that approach.

[Alejandro G. Castro]

(In reply to comment #2)
> (From update of attachment 239611 [details])
> Two thoughts:
> 
> 1) We should also check that "false" is case sensitive. I presume there is some case where the default for stretchy is true, and "false" changes it back to false, but "False" does not.
> 
> 2) Tests that explain what the results should look like are generally better than tests that don't. Even though this is a reference test it would be nice if it was self-explanatory in the browser. In many cases I put expected results in the original as well as the expected file so a human being can compare things visually, and then put the expected result twice in the expected.html file. For example, fast/text/international/old-turkic-direction.html takes that approach.

Thanks for the proposals, I'll add both of them before landing.

[Alejandro G. Castro]

Landed http://trac.webkit.org/changeset/174680

Thanks!