Bug 137598 – Style fixes in FTPDirectoryParser

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: New Bugs

[Adrien Destugues]

Style fixes in FTPDirectoryParser

[Adrien Destugues]

Created attachment 239607 [details]
Patch

[WebKit Commit Bot]

Attachment 239607 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adrien Destugues]

Created attachment 239613 [details]
Patch

[Csaba Osztrogonác]

Comment on attachment 239613 [details]
Patch

We don't do only style fixes, because it would broke the git/svn blame of the files.
( https://lists.webkit.org/pipermail/webkit-dev/2011-October/018324.html )

[Csaba Osztrogonác]

Comment on attachment 239613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239613&action=review

> Source/WebCore/loader/FTPDirectoryParser.cpp:1035
> +                    int now = (state.nowFTPTime.tm_mon << 5) + state.nowFTPTime.tm_mday;
> +                    int modifiedTime = (state.modifiedTime.tm_mon << 5) + state.modifiedTime.tm_mday;
> +                    if (now < modified)
> +                        result.modifiedTime.tm_year--;

It isn't a style change only, you introduced new temporary variables.

[Adrien Destugues]

Ok, my goal is to submit a fix for https://bugs.webkit.org/show_bug.cgi?id=45113 (which is just a one-line fix). Should I ignore style issues in the file then?

The code could also use some refactoring, but there is no testsuite for FTP dir support and I'm not sure if it's possible to add that without an actual collection of FTP servers. So I'm not willing to do more invasive changes there.

[Anne van Kesteren]

*** This bug has been marked as a duplicate of bug 221675 ***