Bug 137598 - Style fixes in FTPDirectoryParser
Summary: Style fixes in FTPDirectoryParser
Status: RESOLVED DUPLICATE of bug 221675
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-10 01:23 PDT by Adrien Destugues
Modified: 2023-12-23 02:09 PST (History)
4 users (show)

See Also:

Attachments
Patch (134.34 KB, patch)
2014-10-10 01:23 PDT, Adrien Destugues 		no flags Details | Formatted Diff | Diff
Patch (134.39 KB, patch)
2014-10-10 03:01 PDT, Adrien Destugues 		ossy: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrien Destugues 2014-10-10 01:23:15 PDT 
Style fixes in FTPDirectoryParser
Comment 1 Adrien Destugues 2014-10-10 01:23:52 PDT 
Created attachment 239607 [details]
Patch
Comment 2 WebKit Commit Bot 2014-10-10 01:26:03 PDT 
Attachment 239607 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adrien Destugues 2014-10-10 03:01:13 PDT 
Created attachment 239613 [details]
Patch
Comment 4 Csaba Osztrogonác 2014-10-10 03:37:40 PDT 
Comment on attachment 239613 [details]
Patch

We don't do only style fixes, because it would broke the git/svn blame of the files.
( https://lists.webkit.org/pipermail/webkit-dev/2011-October/018324.html )
Comment 5 Csaba Osztrogonác 2014-10-10 03:50:18 PDT 
Comment on attachment 239613 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239613&action=review

> Source/WebCore/loader/FTPDirectoryParser.cpp:1035
> +                    int now = (state.nowFTPTime.tm_mon << 5) + state.nowFTPTime.tm_mday;
> +                    int modifiedTime = (state.modifiedTime.tm_mon << 5) + state.modifiedTime.tm_mday;
> +                    if (now < modified)
> +                        result.modifiedTime.tm_year--;

It isn't a style change only, you introduced new temporary variables.
Comment 6 Adrien Destugues 2014-10-10 04:08:19 PDT 
Ok, my goal is to submit a fix for https://bugs.webkit.org/show_bug.cgi?id=45113 (which is just a one-line fix). Should I ignore style issues in the file then?

The code could also use some refactoring, but there is no testsuite for FTP dir support and I'm not sure if it's possible to add that without an actual collection of FTP servers. So I'm not willing to do more invasive changes there.
Comment 7 Anne van Kesteren 2023-12-23 02:09:11 PST 

*** This bug has been marked as a duplicate of bug 221675 ***