Bug 137595 - Use is<>() / downcast<>() for GraphicsLayer subclasses
Summary: Use is<>() / downcast<>() for GraphicsLayer subclasses
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 137056
Blocks:
  Show dependency tree / graph
 
Reported: 2014-10-09 21:03 PDT by Chris Dumez
Modified: 2014-10-10 10:51 PDT (History)
9 users (show)

See Also:

Attachments
Patch (22.61 KB, patch)
2014-10-09 21:15 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (645.00 KB, application/zip)
2014-10-10 00:42 PDT, Build Bot 		no flags Details
Patch (22.60 KB, patch)
2014-10-10 08:33 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (22.81 KB, patch)
2014-10-10 09:49 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2014-10-09 21:03:46 PDT 
Use is<>() / downcast<>() for GraphicsLayer subclasses
Comment 1 Chris Dumez 2014-10-09 21:15:54 PDT 
Created attachment 239599 [details]
Patch
Comment 2 Build Bot 2014-10-10 00:42:12 PDT 
Comment on attachment 239599 [details]
Patch

Attachment 239599 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5451520141164544

New failing tests:
mathml/opentype/munderover-window-resize.html
Comment 3 Build Bot 2014-10-10 00:42:17 PDT 
Created attachment 239606 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 4 Chris Dumez 2014-10-10 08:33:13 PDT 
Created attachment 239627 [details]
Patch
Comment 5 Darin Adler 2014-10-10 09:43:01 PDT 
Comment on attachment 239627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239627&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3200
>          size_t numChildren = childLayers.size();
>          for (size_t i = 0; i < numChildren; ++i) {

Should use a modern for loop.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3203
>                  clonalSublayers.append(childLayer);

Should be childLayer.release().
Comment 6 Chris Dumez 2014-10-10 09:49:35 PDT 
Created attachment 239632 [details]
Patch
Comment 7 WebKit Commit Bot 2014-10-10 10:51:04 PDT 
Comment on attachment 239632 [details]
Patch

Clearing flags on attachment: 239632

Committed r174602: <http://trac.webkit.org/changeset/174602>
Comment 8 WebKit Commit Bot 2014-10-10 10:51:09 PDT 
All reviewed patches have been landed.  Closing bug.