Bug 137595 – Use is<>() / downcast<>() for GraphicsLayer subclasses

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Chris Dumez]

Use is<>() / downcast<>() for GraphicsLayer subclasses

[Chris Dumez]

Created attachment 239599 [details]
Patch

[Build Bot]

Comment on attachment 239599 [details]
Patch

Attachment 239599 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5451520141164544

New failing tests:
mathml/opentype/munderover-window-resize.html

[Build Bot]

Created attachment 239606 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Chris Dumez]

Created attachment 239627 [details]
Patch

[Darin Adler]

Comment on attachment 239627 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239627&action=review

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3200
>          size_t numChildren = childLayers.size();
>          for (size_t i = 0; i < numChildren; ++i) {

Should use a modern for loop.

> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:3203
>                  clonalSublayers.append(childLayer);

Should be childLayer.release().

[Chris Dumez]

Created attachment 239632 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 239632 [details]
Patch

Clearing flags on attachment: 239632

Committed r174602: <http://trac.webkit.org/changeset/174602>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.