RESOLVED FIXED 137564
Web Inspector: Remove unused generator code 
https://bugs.webkit.org/show_bug.cgi?id=137564
Summary Web Inspector: Remove unused generator code
Joseph Pecoraro
Reported 2014-10-09 12:57:33 PDT
Some unused code in the generator. Lets clean it up.
Attachments
[PATCH] Proposed Fix (8.56 KB, patch)
2014-10-09 12:59 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2014-10-09 12:59:04 PDT
Created attachment 239561 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2014-10-09 13:01:46 PDT
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Brian Burg
Comment 3 2014-10-09 13:36:39 PDT
Comment on attachment 239561 [details] [PATCH] Proposed Fix Looks fine to me. Does this affect any generator test results?
WebKit Commit Bot
Comment 4 2014-10-09 22:53:58 PDT
Comment on attachment 239561 [details] [PATCH] Proposed Fix Clearing flags on attachment: 239561 Committed r174559: <http://trac.webkit.org/changeset/174559>
WebKit Commit Bot
Comment 5 2014-10-09 22:54:00 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 6 2014-10-10 11:24:32 PDT
(In reply to comment #3) > (From update of attachment 239561 [details]) > Looks fine to me. Does this affect any generator test results? I should have mentioned I ran tests and they all passed. Thanks for the review!
Note You need to log in before you can comment on or make changes to this bug.