Bug 137564 - Web Inspector: Remove unused generator code
Summary: Web Inspector: Remove unused generator code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2014-10-09 12:57 PDT by Joseph Pecoraro
Modified: 2014-10-10 11:24 PDT (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (8.56 KB, patch)
2014-10-09 12:59 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-10-09 12:57:33 PDT 
Some unused code in the generator. Lets clean it up.
Comment 1 Joseph Pecoraro 2014-10-09 12:59:04 PDT 
Created attachment 239561 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2014-10-09 13:01:46 PDT 
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 3 Brian Burg 2014-10-09 13:36:39 PDT 
Comment on attachment 239561 [details]
[PATCH] Proposed Fix

Looks fine to me. Does this affect any generator test results?
Comment 4 WebKit Commit Bot 2014-10-09 22:53:58 PDT 
Comment on attachment 239561 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 239561

Committed r174559: <http://trac.webkit.org/changeset/174559>
Comment 5 WebKit Commit Bot 2014-10-09 22:54:00 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Joseph Pecoraro 2014-10-10 11:24:32 PDT 
(In reply to comment #3)
> (From update of attachment 239561 [details])
> Looks fine to me. Does this affect any generator test results?

I should have mentioned I ran tests and they all passed. Thanks for the review!