Bug 137563 - Remove MainThreadTask
Summary: Remove MainThreadTask
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-09 12:37 PDT by Zan Dobersek
Modified: 2014-10-16 11:15 PDT (History)
3 users (show)

See Also:

Attachments
Patch (11.71 KB, patch)
2014-10-09 12:38 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch for landing (11.59 KB, patch)
2014-10-09 23:31 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (24.95 KB, patch)
2014-10-16 11:02 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2014-10-09 12:37:12 PDT 
Remove MainThreadTask
Comment 1 Zan Dobersek 2014-10-09 12:38:54 PDT 
Created attachment 239559 [details]
Patch
Comment 2 Alexey Proskuryakov 2014-10-09 20:50:44 PDT 
Comment on attachment 239559 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239559&action=review

> Source/WebCore/platform/network/curl/CurlDownload.cpp:36
> -#include <wtf/MainThread.h>
> +#include <wtf/MainThread.h>Æ

How did this pass EWS?
Comment 3 Zan Dobersek 2014-10-09 23:30:38 PDT 
Comment on attachment 239559 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=239559&action=review

>> Source/WebCore/platform/network/curl/CurlDownload.cpp:36
>> +#include <wtf/MainThread.h>Æ
> 
> How did this pass EWS?

This file is only used by the WinCairo port, which has no EWS systems operating.
Comment 4 Zan Dobersek 2014-10-09 23:31:17 PDT 
Created attachment 239601 [details]
Patch for landing
Comment 5 Zan Dobersek 2014-10-10 02:36:03 PDT 
Comment on attachment 239601 [details]
Patch for landing

Clearing flags on attachment: 239601

Committed r174579: <http://trac.webkit.org/changeset/174579>
Comment 6 Zan Dobersek 2014-10-10 02:36:11 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Andy Estes 2014-10-16 11:01:57 PDT 
Reopening to attach new patch.
Comment 8 Andy Estes 2014-10-16 11:02:03 PDT 
Created attachment 239952 [details]
Patch
Comment 9 Andy Estes 2014-10-16 11:15:18 PDT 
Sorry, webkit-patch posted to the wrong bug somehow. I think I posted in the middle of ddkilzer's upgrade.