Get the patch scripts running on Haiku
Created attachment 239538 [details]
Comment on attachment 239538 [details]
Clearing flags on attachment: 239538
Committed r174521: <http://trac.webkit.org/changeset/174521>
All reviewed patches have been landed. Closing bug.
6 py tests failing on Windows:
This broke the script for me (in Debian), not sure why.
$ Tools/Scripts/commit-log-editor --print-log Source/WebCore/ChangeLog
/usr/bin/env: perl -w: No such file or directory
However, this works:
$ /usr/bin/env perl -w Tools/Scripts/commit-log-editor --print-log Source/WebCore/ChangeLog
hmm, it seems the problem is the -w that is considered the script instead of a command line option
As a workaround I've created a sh script called "perl -w" in my path that actually calls perl -w $*
Sorry, I forgot that support for multiple arguments was missing on Linux. A possible fix is removing the -w switch and using "use warnings;" instead, would that be ok?
The problem is that Linux and CygWin pass "perl -w"
as one argument which causes the error:
Now prepare-changelog, commit-log-editor and almost everything
is broken on Linux, so we have to fix it ASAP.
(In reply to comment #8)
> Sorry, I forgot that support for multiple arguments was missing on Linux. A possible fix is removing the -w switch and using "use warnings;" instead, would that be ok?
Good idea. Could you file a new bug report and change all -w to "use warnings"
in all perl scripts in Tools? Otherwise we can use "#!/usr/bin/env perl" shebang
everywhere, not only in these scripts.