RESOLVED FIXED 137559
Get the patch scripts running on Haiku 
https://bugs.webkit.org/show_bug.cgi?id=137559
Summary Get the patch scripts running on Haiku
Adrien Destugues
Reported 2014-10-09 07:48:39 PDT
Get the patch scripts running on Haiku
Attachments
Patch (3.58 KB, patch)
2014-10-09 07:55 PDT, Adrien Destugues 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrien Destugues
Comment 1 2014-10-09 07:55:14 PDT
Created attachment 239538 [details] Patch
WebKit Commit Bot
Comment 2 2014-10-09 12:52:11 PDT
Comment on attachment 239538 [details] Patch Clearing flags on attachment: 239538 Committed r174521: <http://trac.webkit.org/changeset/174521>
WebKit Commit Bot
Comment 3 2014-10-09 12:52:14 PDT
All reviewed patches have been landed. Closing bug.
Carlos Garcia Campos
Comment 5 2014-10-09 23:32:47 PDT
This broke the script for me (in Debian), not sure why. $ Tools/Scripts/commit-log-editor --print-log Source/WebCore/ChangeLog /usr/bin/env: perl -w: No such file or directory However, this works: $ /usr/bin/env perl -w Tools/Scripts/commit-log-editor --print-log Source/WebCore/ChangeLog
Carlos Garcia Campos
Comment 6 2014-10-09 23:44:52 PDT
hmm, it seems the problem is the -w that is considered the script instead of a command line option
Carlos Garcia Campos
Comment 7 2014-10-09 23:54:15 PDT
As a workaround I've created a sh script called "perl -w" in my path that actually calls perl -w $*
Adrien Destugues
Comment 8 2014-10-10 01:55:01 PDT
Sorry, I forgot that support for multiple arguments was missing on Linux. A possible fix is removing the -w switch and using "use warnings;" instead, would that be ok?
Csaba Osztrogonác
Comment 9 2014-10-10 02:05:30 PDT
The problem is that Linux and CygWin pass "perl -w" as one argument which causes the error: - http://en.wikipedia.org/wiki/Shebang_%28Unix%29 - http://mail-index.netbsd.org/netbsd-users/2008/11/09/msg002388.html Now prepare-changelog, commit-log-editor and almost everything is broken on Linux, so we have to fix it ASAP.
Csaba Osztrogonác
Comment 10 2014-10-10 02:08:52 PDT
(In reply to comment #8) > Sorry, I forgot that support for multiple arguments was missing on Linux. A possible fix is removing the -w switch and using "use warnings;" instead, would that be ok? Good idea. Could you file a new bug report and change all -w to "use warnings" in all perl scripts in Tools? Otherwise we can use "#!/usr/bin/env perl" shebang everywhere, not only in these scripts.
Adrien Destugues
Comment 11 2014-10-10 02:35:34 PDT
https://bugs.webkit.org/show_bug.cgi?id=137601
Note You need to log in before you can comment on or make changes to this bug.